feat(toDash): Add the "dub" role to translated captions #677
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can ask YouTube to translate a caption track with machine translation by adding the
tlangquery parameter with your desired locale. This pull request adds todubrole to those caption tracks when adding them to the DASH manifest.Unfortunately there doesn't seem to be a suitable role value in the
urn:mpeg:dash:role:2011scheme for auto-generated captions (kind=asr), so we don't currently have a way to tag those inside the DASH manifest, unless we want to create a custom scheme.