Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Kids): Add blockChannel command to easily block channels #503

Merged
merged 7 commits into from
Oct 28, 2023

Conversation

rsandbach
Copy link
Contributor

Added new command and classes to support the Report / Block channel for kids

image

Small change to ToggleButton to allow parsing when there is now defaultIcon defined.

@rsandbach
Copy link
Contributor Author

This would be a start to #422.

@absidue
Copy link
Collaborator

absidue commented Sep 12, 2023

Probably better to put the kids only block channel in src/core/clients/Kids.ts instead of the interaction manager, as they presumably can't be used for YouTube or YouTube Music?

Please place your new kids only parser classes in the src/parser/classes/ytkids instead of src/parser/classes/channels.

@rsandbach
Copy link
Contributor Author

I went back and forth on this. My initial implementation was under Kids, but these particular actions/UI elements are only available within the YouTube web client when logged into an account that curates content for supervised accounts/kids profiles.

@LuanRT
Copy link
Owner

LuanRT commented Sep 18, 2023

Just skimming through the code and it looks good. Will do a proper review tomorrow or Tuesday.

Edit:
Done! :)

@LuanRT LuanRT changed the title Add blockChannel command to easily block channels feat(Kids): Add blockChannel command to easily block channels Sep 18, 2023
@LuanRT LuanRT merged commit 9ab528e into LuanRT:main Oct 28, 2023
3 checks passed
@ChipWolf
Copy link

ChipWolf commented Nov 5, 2023

Probably better to put the kids only block channel in src/core/clients/Kids.ts instead of the interaction manager, as they presumably can't be used for YouTube or YouTube Music?

Please place your new kids only parser classes in the src/parser/classes/ytkids instead of src/parser/classes/channels.

This is nothing to do with ytkids. This is for supervised child accounts that are set to 'Explore', giving them access to yt proper.

@rsandbach rsandbach deleted the add-block-channel-for-kids branch November 11, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants