Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VideoSecondaryInfo): add support for attributed descriptions #325

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

LuanRT
Copy link
Owner

@LuanRT LuanRT commented Feb 26, 2023

Description

Adds support for YouTube's new attributed descriptions and its attachment runs.

The library should now be able to provide the data correctly as well as generate valid html with for the description. Here's an example of a description rendered by YouTube.js:

Old description type:
Screenshot_20230226-163747

Attributed description:
Screenshot_20230226-163023

As seen above, this new description type treats YouTube specific links differently instead of rendering them like other links.

Closes #319

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@LuanRT LuanRT merged commit f933cb4 into main Feb 26, 2023
@LuanRT LuanRT deleted the feature/attributed-description branch February 26, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle VideoSecondaryInfo's attributedDescription prop
1 participant