Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ChannelAboutFullMetadata) Fix error when there are no primary links #299

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

absidue
Copy link
Collaborator

@absidue absidue commented Jan 29, 2023

Description

Some channels don't have any primary links, think the channels that get generated for every user account but most YouTube users probably don't even know that they have a channel associated with their account.

Currently it prints a warning because it's calling .map on undefined in those situations.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@LuanRT LuanRT merged commit f62c66d into LuanRT:main Jan 30, 2023
@absidue absidue deleted the channel-about-primary-links branch January 30, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants