Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition for transition to float #895

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

cflenker
Copy link
Contributor

@cflenker cflenker commented Dec 21, 2023

I often observe the following behaviour:
When reaching MAX_CELL_VOLTAGE and the current is dropping towards zero the cells with higher voltage come down and the cells with lower voltage come up, then crossing each other and drifting away again before the balancer brings them finally all together.
At the point of time when they are crossing (celldiff<CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_UNTIL) the battery pack seems to be balanced an the timer of MAX_VOLTAGE_TIME_SEC starts. So after MAX_VOLTAGE_TIME_SEC the control_voltage is lowered to FLOAT-Voltage no matter how well they are together at this point of time (as long as they are not more than CELL_VOLTAGE_DIFF_TO_RESET_VOLTAGE_LIMIT away from each other).
In reality the battery is not completely balanced and MAX_VOLTAGE is stopped to early:
image

My proposal would be to introduce one more threshold for cell-deviation that causes MAX_VOLTAGE_TIME_SEC to restart if celldiff gets above this threshold:
image

So celldiff has to be smaller than CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_TIME_RESTART for MAX_VOLTAGE_TIME_SEC to start the transition to float.

As default value CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_TIME_RESTART can be choosen much bigger than CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_UNTIL so this change has no impact for existing configurations and to prevent that some configurations (where the celldiff has a lot of noise) would never change to float.

For my configuration it has a very positiv effect:
image

@mr-manuel
Copy link
Collaborator

Nice catch :-)

@mr-manuel mr-manuel merged commit 06dff6d into Louisvdw:dev Dec 23, 2023
@cflenker
Copy link
Contributor Author

Thanks a lot for merging this commit!

@mr-manuel
Copy link
Collaborator

Thank you for this great improvements :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants