Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PS1 save crystal model and texture #1069

Closed
VGMFR opened this issue Nov 9, 2023 · 7 comments
Closed

Implement PS1 save crystal model and texture #1069

VGMFR opened this issue Nov 9, 2023 · 7 comments
Labels
Duplicate This issue or pull request already exists TR1

Comments

@VGMFR
Copy link

VGMFR commented Nov 9, 2023

Having the option to play with the PS1 crystal is one of the best options in my humble opinion, a dream that became true.

However, here is how crystals look on PS1:

image

A beautiful blue with a nice reflection effect.

Here is how they currently look on TRX:
image
image

Note quite as beautiful. So it would be incredible to have the original model back, if possible with reflection. But for reflection another issue already exists: #154
I also found this source of information regarding the subject:
https://www.tombraiderforums.com/showthread.php?t=226585

@tommapar97
Copy link

A note that could help for future reference when reviewing this.

Apparently the reflections on the crystal- as well as the rolling blades in the first level of TR2 where the output of one of PS1's buffers that just was the the output of THE SCREEN ITSELF, on real time, on a pixel basis, then projected onto the UV of the crystal, and then it was just multiplied by a shade of blue, while for the rolling blade it was just inverted IIRC.

It's literally the simplest SSR technique available. My 2 cents as a game designer, and from what OpenLara did: adding a glue blow (blue glow) to it would be also nice, adding point lights would make them easier to see and no one would complain. PS1 era coloured lighting is amazing. Just look at how big a change it made when switching from TR2 to TR3.

@walkawayy
Copy link
Collaborator

Yes we would love to implement this reflection effect hence the issue already existing. I think unfortunately at the moment, none of the devs have a good 3D graphics background to implement it. We welcome contributions if anyone is able to help!

@walkawayy walkawayy added the Duplicate This issue or pull request already exists label Nov 18, 2023
@VGMFR
Copy link
Author

VGMFR commented Nov 18, 2023

Yes I noticed the open issue regarding reflection (and linked it in the original message as well), but this issue was more to restore the blue color / texture of the original crystal, which can be done independently from reflection, as well as the 3D model if it's not exactly the same (look quite similar thought, but I did not push the comparison further).

To be more precise, the color for the original save crystal is #4040FF according to the thread linked above, when the current one in TR1X seems to be #93adac.

For the 3D model, more comparisons and possibly investigation would be needed, but it is less noticeable than the color anyway.

@VGMFR
Copy link
Author

VGMFR commented Dec 15, 2023

Quick update for this issue if anyone else was wondering: the crystal color of TR1X seems in fact to be the one of the Saturn version of TR1, a version that released before it was finished. So it could maybe be nice for some people to have the option to chose the Saturn crystals color #93adac) or the PS1 crystal color (#4040FF), but not to replace the Saturn by the PS1 (even if PS1 really looks better in my humble opinion :')).

@pas-de-2
Copy link
Contributor

I was messing around with Sabatu's TR1 wads + textures pack in Tomb Editor and noticed he has a pretty nice looking save crystal, could maybe inject something like this as a stopgap:

20231220_224149_Caves

@VGMFR
Copy link
Author

VGMFR commented Dec 22, 2023

I was messing around with Sabatu's TR1 wads + textures pack in Tomb Editor and noticed he has a pretty nice looking save crystal, could maybe inject something like this as a stopgap:

20231220_224149_Caves

Very nice indeed! Very close to the original PS1 one.

@rr-
Copy link
Collaborator

rr- commented Mar 31, 2024

Thanks for the comments. This will be tackled as part of #154 efforts.

@rr- rr- closed this as completed Mar 31, 2024
@rr- rr- closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2024
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate This issue or pull request already exists TR1
Projects
None yet
Development

No branches or pull requests

5 participants