Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

TR2X bug: Game doesn't start instantaneous after Load Game or New Game #114

Closed
aredfan opened this issue Jul 22, 2024 · 5 comments · Fixed by LostArtefacts/libtrx#11
Closed
Labels
TR2 TRX bug A bug with TR2X
Milestone

Comments

@aredfan
Copy link

aredfan commented Jul 22, 2024

Dev snapshot: 0.2-141-g5752c50


In both videos, the first part is TR2X and the second part is OG.

Load Game

The holdup is when the menu/inventory ring closes.

Video.1.mp4

New Game

The holdup is a black screen.

Video.2.mp4
@aredfan aredfan added the TRX bug A bug with TR2X label Jul 22, 2024
@Richard-L
Copy link

I believe this might be the same as LostArtefacts/TRX#1335

@rr-
Copy link
Collaborator

rr- commented Jul 22, 2024

Actually I think this is the same issue as this: LostArtefacts/TRX#1597

@aredfan aredfan changed the title TR2X bug: Game doesn't start instantaneous after Quick Load or New Game TR2X bug: Game doesn't start instantaneous after Load Game or New Game Jul 22, 2024
@rr-
Copy link
Collaborator

rr- commented Jul 23, 2024

@aredfan can you play around with this version?
https://nebula.wind.garden/serve/pub/TR2X-0.2-143-g10d8d69-dirty-Windows.zip
I've updated the audio engine to convert samples on-demand, upon first use. However, since we're still not using background threads for this task, this change could potentially result in occasional audio clicks. To help in assessing how well this works, we log the time each conversion task takes in milliseconds.

@aredfan
Copy link
Author

aredfan commented Jul 23, 2024

@rr- Yep, always happy to help out.

I played through the Opera House level with this build and I believe I didn't encounter any audio clicks. I also checked the TR2X.log after quitting the game a few times - the audio sample conversion is consistently 0 ms across the board.

My PC is coming up to 4 years old if it's relevant.

I also noticed the holdup issue for New Game and Load Game is fixed in this build.

@rr-
Copy link
Collaborator

rr- commented Jul 23, 2024

Thanks – I'll wait for @Richard-L report coming around the weekend too and if it works fine on his end, I'll merge the changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
TR2 TRX bug A bug with TR2X
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants