Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UEFIReplace: reconstructVolume: root volume can't be grown #154

Closed
KingBonecrusher opened this issue Dec 23, 2018 · 4 comments
Closed

UEFIReplace: reconstructVolume: root volume can't be grown #154

KingBonecrusher opened this issue Dec 23, 2018 · 4 comments

Comments

@KingBonecrusher
Copy link

I failed to remove a dxe driver with latest UEFITool 0.25.1. I have also tried uefireplace cli tool, but same error. I have extracted the volume -->

https://www.file-upload.net/download-13443293/Volume_FFSv2_EfiFirmwareFileSystem2Guid.vol.html

@KingBonecrusher
Copy link
Author

Update:

Removing at least 4 or 5 dxe modules at once with UEFITool 0.25.1 is working for me. It seems the compression of uefitool is slightly bigger as the original from the dump. Is there any way/option to make a stronger compression?

@vit9696
Copy link
Contributor

vit9696 commented Dec 24, 2018

The issue most likely happens due to hardcoded LZMA_DICTIONARY_SIZE value (0x800000), which is most likely bigger in your files. The dictionary size in modern BIOSes is present as the first UINT32 of the data blob, and it needs to be handled (thus the the TODO in LzmaCompress.c).

I do not foresee this getting fixed in master in the nearest future, and NE still has a long way to builder introduction, so what you could temporarily try is using your own value and recompiling UEFITool with it.

@KingBonecrusher
Copy link
Author

Thanks, your hint has done it! Can be closed...

@vit9696
Copy link
Contributor

vit9696 commented Dec 24, 2018

Glad to hear. It remains to be an issue though, I will leave it open until we handle compression buffer size properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants