From 8a5f37ae20f02c044ffb720666c811e6bef052c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Thu, 21 Nov 2024 18:57:17 +0100 Subject: [PATCH 1/2] Update Atata.WebDriverSetup package to v3.1.0 --- Lombiq.Tests.UI/Lombiq.Tests.UI.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj b/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj index 197ac4883..0ae227447 100644 --- a/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj +++ b/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj @@ -69,7 +69,7 @@ - + From a8426eb1cf9ccddafd9c02234d937dd9f00e7434 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Thu, 21 Nov 2024 18:57:49 +0100 Subject: [PATCH 2/2] Revert "Skipping Edge tests" This reverts commit 8a7e8c38b7a02ee3fb4f3b932cc479979647a3be. --- .../Tests/BasicVisualVerificationTests.cs | 3 +-- Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs | 7 ++----- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs b/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs index d62bf0592..a2372dec0 100644 --- a/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs +++ b/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs @@ -55,8 +55,7 @@ public Task VerifyBlogImage() => // is the different rendering of text on each platform, but it can occur between different Linux distributions too. // Here: https://pandasauce.org/post/linux-fonts/ you can find a good summary about this from 2019, but still valid // in 2022. - // Temporarily not running Edge until https://github.com/atata-framework/atata-webdriversetup/issues/16 is fixed. - [Theory, Chrome] + [Theory, Chrome, Edge] public Task VerifyNavbar(Browser browser) => ExecuteTestAfterSetupAsync( context => diff --git a/Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs b/Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs index 7dc7eec6f..c410f92be 100644 --- a/Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs +++ b/Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs @@ -23,9 +23,7 @@ public MultiBrowserTests(ITestOutputHelper testOutputHelper) // First, let's see a test using Edge. While the default browser is Chrome if you don't set anything, all // ExecuteTest* methods can also accept a browser, if you want to use a different one. -#pragma warning disable xUnit1004 // Test methods should not be skipped - [Fact(Skip = "Temporarily not running Edge until https://github.com/atata-framework/atata-webdriversetup/issues/16 is fixed.")] -#pragma warning restore xUnit1004 // Test methods should not be skipped + [Fact] public Task AnonymousHomePageShouldExistWithEdge() => ExecuteTestAfterSetupAsync(NavbarIsCorrect, Browser.Edge); @@ -33,8 +31,7 @@ public Task AnonymousHomePageShouldExistWithEdge() => // tests. [Chrome] and [Edge] are input parameters of the test, and thus in effect, you have now two tests: // AnonymousHomePageShouldExistMultiBrowser once with Chrome, and once with Edge. See here for more info: // https://andrewlock.net/creating-parameterised-tests-in-xunit-with-inlinedata-classdata-and-memberdata/. - // Temporarily not running Edge until https://github.com/atata-framework/atata-webdriversetup/issues/16 is fixed. - [Theory, Chrome] + [Theory, Chrome, Edge] public Task AnonymousHomePageShouldExistMultiBrowser(Browser browser) => ExecuteTestAfterSetupAsync(NavbarIsCorrect, browser);