diff --git a/.github/workflows/publish-nuget.yml b/.github/workflows/publish-nuget.yml index 4b26cfcf9..655acc602 100644 --- a/.github/workflows/publish-nuget.yml +++ b/.github/workflows/publish-nuget.yml @@ -7,6 +7,6 @@ on: jobs: publish-nuget: - uses: Lombiq/GitHub-Actions/.github/workflows/publish-nuget.yml@dev + uses: Lombiq/GitHub-Actions/.github/workflows/publish-nuget.yml@issue/OSOE-842 secrets: API_KEY: ${{ secrets.DEFAULT_NUGET_PUBLISH_API_KEY }} diff --git a/Lombiq.Tests.UI.Samples/Tests/MonkeyTests.cs b/Lombiq.Tests.UI.Samples/Tests/MonkeyTests.cs index b8b7738ae..363c31c2a 100644 --- a/Lombiq.Tests.UI.Samples/Tests/MonkeyTests.cs +++ b/Lombiq.Tests.UI.Samples/Tests/MonkeyTests.cs @@ -101,6 +101,7 @@ public Task TestAdminBackgroundTasksAsMonkeyRecursivelyShouldWorkWithAdminUser() && !logEntry .Message .Contains("An invalid form control with name='LockExpiration' is not focusable.") + && !logEntry.IsNotFoundLogEntry("/favicon.ico") && logEntry.Level != LogLevel.Info) .ShouldBeEmpty()); diff --git a/Lombiq.Tests.UI/Services/WebDriverFactory.cs b/Lombiq.Tests.UI/Services/WebDriverFactory.cs index d27325bdc..630fef7cb 100644 --- a/Lombiq.Tests.UI/Services/WebDriverFactory.cs +++ b/Lombiq.Tests.UI/Services/WebDriverFactory.cs @@ -22,17 +22,13 @@ public static Task CreateChromeDriverAsync(BrowserConfiguration co { Task CreateDriverInnerAsync(ChromeDriverService service) { + // Note that no-sandbox should NOT be used, because it causes Chrome processes to remain open, see + // https://github.com/Lombiq/UI-Testing-Toolbox/issues/356. + var chromeConfig = new ChromeConfiguration { Options = new ChromeOptions().SetCommonOptions() }; chromeConfig.Options.SetLoggingPreference(LogType.Browser, LogLevel.Info); - // Disabling the Chrome sandbox can speed things up a bit, so it's recommended when you get a lot of - // timeouts during parallel execution: - // https://stackoverflow.com/questions/22322596/selenium-error-the-http-request-to-the-remote-webdriver-timed-out-after-60-sec - // However, this makes the executing machine vulnerable to browser-based attacks so it should only be used - // with trusted code (like our own). - chromeConfig.Options.AddArgument("no-sandbox"); - // Linux-specific setting, may be necessary for running in containers, see // https://developers.google.com/web/tools/puppeteer/troubleshooting#tips for more information. chromeConfig.Options.AddArgument("disable-dev-shm-usage"); // #spell-check-ignore-line