Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome processes remaining after concurrent headless tests finish (OSOE-839) #356

Closed
Piedone opened this issue Apr 24, 2024 · 4 comments · Fixed by #360
Closed

Chrome processes remaining after concurrent headless tests finish (OSOE-839) #356

Piedone opened this issue Apr 24, 2024 · 4 comments · Fixed by #360
Assignees
Labels
bug Something isn't working

Comments

@Piedone
Copy link
Member

Piedone commented Apr 24, 2024

Under Windows (didn't test other platforms), Chrome processes remain open after tests finish. Standard mode doesn't exhibit this issue.

See Lombiq/Open-Source-Orchard-Core-Extensions#738 (comment) and Lombiq/Open-Source-Orchard-Core-Extensions#738 (comment) for details. Contrary to what's written there though, this does happen in non-headless mode too, and also for single tests: Chrome processes (more than one for a test) are kept open, even though the Chrome Windows are closed.

This also happens with a single test being run: it'll leave 4 chrome.exe processes running, with 2 consuming some CPU (those relating to a test opening one Chrome for the Orchard Core setup, and another one for the test itself; no idea why there are two more processes).

This might just be fixed by #355.

Might be related: SeleniumHQ/selenium#13595.

Jira issue

@Piedone Piedone added the bug Something isn't working label Apr 24, 2024
@github-actions github-actions bot changed the title Chrome processes remaining after concurrent headless tests finish Chrome processes remaining after concurrent headless tests finish (OSOE-839) Apr 24, 2024
@Piedone
Copy link
Member Author

Piedone commented Apr 29, 2024

This might be behind #358.

@YevgeniyShunevych have you noticed Chrome processes not closing by chance?

@Piedone
Copy link
Member Author

Piedone commented Apr 30, 2024

Hmm, removing no-sandbox fixes the issue in headless and non-headless too.

@Piedone
Copy link
Member Author

Piedone commented Apr 30, 2024

@AydinE please watch this and merge from the OSOCE dev once this is closed.

@Piedone
Copy link
Member Author

Piedone commented Apr 30, 2024

Or merge from the issue/OSOE-840 branch already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant