From 7c2ef255bedce4a57652885c8385800b6603db3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 9 Feb 2024 02:25:37 +0100 Subject: [PATCH 01/50] Walkthrough cleaned up and test steps added up until going to the main menu editor --- src/Modules/Lombiq.Walkthroughs | 2 +- test/Lombiq.UITestingToolbox | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index 3600052c0..f6ae90c49 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit 3600052c05099051c6a4bf7d02c362dc981f3e6f +Subproject commit f6ae90c494d6ae98db3d4c1ae76c846389415dec diff --git a/test/Lombiq.UITestingToolbox b/test/Lombiq.UITestingToolbox index b73bccf8d..2337e756c 160000 --- a/test/Lombiq.UITestingToolbox +++ b/test/Lombiq.UITestingToolbox @@ -1 +1 @@ -Subproject commit b73bccf8d368257faf841a8dffac8b34204a6c21 +Subproject commit 2337e756c6f96f75faa9f013e3093ce4a70dd3c9 From c5de048a420c1da9321b82ed80f94c24c50ae80f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 9 Feb 2024 02:29:44 +0100 Subject: [PATCH 02/50] ClickReliablyOnByLinkTextAsync() navigation shortcut in Lombiq.UITestingToolbox --- src/Modules/Lombiq.Walkthroughs | 2 +- test/Lombiq.UITestingToolbox | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index f6ae90c49..cf493716f 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit f6ae90c494d6ae98db3d4c1ae76c846389415dec +Subproject commit cf493716f37ef648ebeefdd54d411b834fbaca86 diff --git a/test/Lombiq.UITestingToolbox b/test/Lombiq.UITestingToolbox index 2337e756c..f6224e0c7 160000 --- a/test/Lombiq.UITestingToolbox +++ b/test/Lombiq.UITestingToolbox @@ -1 +1 @@ -Subproject commit 2337e756c6f96f75faa9f013e3093ce4a70dd3c9 +Subproject commit f6224e0c751520e9c9bdeff15bfee6abf59c2402 From 19a6fe94773293aeceb3762b357b714c6e97941b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 11 Feb 2024 04:32:21 +0100 Subject: [PATCH 03/50] Steps up until import --- src/Modules/Lombiq.Walkthroughs | 2 +- .../ModuleTests/BehaviorWalkthroughsTests.cs | 26 ++++++++++++++++--- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index cf493716f..64e9c4d68 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit cf493716f37ef648ebeefdd54d411b834fbaca86 +Subproject commit 64e9c4d68c1b113e7fb956515bf9891fb4ce5371 diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index 6d858df8c..197b85a97 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -1,6 +1,11 @@ +using Lombiq.Tests.UI.Extensions; +using Lombiq.Tests.UI.Services; using Lombiq.Walkthroughs.Tests.UI.Extensions; +using OpenQA.Selenium; +using Shouldly; using System; using System.IO; +using System.Linq; using System.Threading.Tasks; using Xunit; using Xunit.Abstractions; @@ -19,8 +24,21 @@ public Task WalkthroughsShouldWorkCorrectly() => ExecuteTestAsync( context => context.RunSetupAndTestWalkthroughsBehaviorAsync(), // Could be removed if https://github.com/shepherd-pro/shepherd/issues/2555 is fixed. - changeConfiguration: configuration => configuration.HtmlValidationConfiguration.HtmlValidationOptions = - configuration.HtmlValidationConfiguration.HtmlValidationOptions - .CloneWith(validationOptions => validationOptions.ConfigPath = - Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "BehaviorWalkthroughsTests.htmlvalidate.json"))); + changeConfiguration: configuration => + { + configuration.HtmlValidationConfiguration.HtmlValidationOptions = + configuration.HtmlValidationConfiguration.HtmlValidationOptions + .CloneWith(validationOptions => validationOptions.ConfigPath = + Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "BehaviorWalkthroughsTests.htmlvalidate.json")); + + configuration.AssertBrowserLog = logEntries => logEntries.ShouldNotContain( + logEntry => IsValidLogEntry(logEntry), + logEntries.Where(IsValidLogEntry).ToFormattedString()); + }); + + private static bool IsValidLogEntry(LogEntry logEntry) => + OrchardCoreUITestExecutorConfiguration.IsValidBrowserLogEntry(logEntry) && + // See https://github.com/OrchardCMS/OrchardCore/issues/15301. + !logEntry.Message.ContainsOrdinalIgnoreCase( + "/OrchardCore.Resources/Scripts/jquery.js?v=NZgNvzR7iJazTVAtnyirXhsLcMZkO1V7t4f3DXx0vqE 3128:6 Uncaught"); } From a7384acfe16746d1b2c31498c92c4053f7353745 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 11 Feb 2024 20:21:27 +0100 Subject: [PATCH 04/50] Completing all Walkthroughs test steps --- src/Modules/Lombiq.Walkthroughs | 2 +- .../Tests/ModuleTests/BehaviorWalkthroughsTests.cs | 5 ++++- test/Lombiq.UITestingToolbox | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index 64e9c4d68..236d3d263 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit 64e9c4d68c1b113e7fb956515bf9891fb4ce5371 +Subproject commit 236d3d26327d972361a9e1cd9d781a94c88c162e diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index 197b85a97..c053979f0 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -40,5 +40,8 @@ private static bool IsValidLogEntry(LogEntry logEntry) => OrchardCoreUITestExecutorConfiguration.IsValidBrowserLogEntry(logEntry) && // See https://github.com/OrchardCMS/OrchardCore/issues/15301. !logEntry.Message.ContainsOrdinalIgnoreCase( - "/OrchardCore.Resources/Scripts/jquery.js?v=NZgNvzR7iJazTVAtnyirXhsLcMZkO1V7t4f3DXx0vqE 3128:6 Uncaught"); + "/OrchardCore.Resources/Scripts/jquery.js?v=NZgNvzR7iJazTVAtnyirXhsLcMZkO1V7t4f3DXx0vqE 3128:6 Uncaught") && + // See https://github.com/OrchardCMS/OrchardCore/issues/14598. This error has multiple variations, so targeting + // the lower common denominator with the file name. + !logEntry.Message.ContainsOrdinalIgnoreCase("/monaco/IStandaloneEditorConstructionOptions.json"); } diff --git a/test/Lombiq.UITestingToolbox b/test/Lombiq.UITestingToolbox index f6224e0c7..9531cb89f 160000 --- a/test/Lombiq.UITestingToolbox +++ b/test/Lombiq.UITestingToolbox @@ -1 +1 @@ -Subproject commit f6224e0c751520e9c9bdeff15bfee6abf59c2402 +Subproject commit 9531cb89f7ad254d0fea18b36cbbf705a05d4b85 From aa3799e1742b8d3629d3a4a813a0fcdb78750133 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 11 Feb 2024 20:33:13 +0100 Subject: [PATCH 05/50] Spelling --- src/Modules/Lombiq.Walkthroughs | 2 +- .../Tests/ModuleTests/BehaviorWalkthroughsTests.cs | 4 ++-- test/Lombiq.UITestingToolbox | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index 236d3d263..82a07af02 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit 236d3d26327d972361a9e1cd9d781a94c88c162e +Subproject commit 82a07af02911b0ce65e44ad044887c0a93dbb435 diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index c053979f0..9c96d939d 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -39,8 +39,8 @@ public Task WalkthroughsShouldWorkCorrectly() => private static bool IsValidLogEntry(LogEntry logEntry) => OrchardCoreUITestExecutorConfiguration.IsValidBrowserLogEntry(logEntry) && // See https://github.com/OrchardCMS/OrchardCore/issues/15301. - !logEntry.Message.ContainsOrdinalIgnoreCase( - "/OrchardCore.Resources/Scripts/jquery.js?v=NZgNvzR7iJazTVAtnyirXhsLcMZkO1V7t4f3DXx0vqE 3128:6 Uncaught") && + !(logEntry.Message.ContainsOrdinalIgnoreCase("/OrchardCore.Resources/Scripts/jquery.js?v=") && + logEntry.Message.ContainsOrdinalIgnoreCase("3128:6 Uncaught")) && // See https://github.com/OrchardCMS/OrchardCore/issues/14598. This error has multiple variations, so targeting // the lower common denominator with the file name. !logEntry.Message.ContainsOrdinalIgnoreCase("/monaco/IStandaloneEditorConstructionOptions.json"); diff --git a/test/Lombiq.UITestingToolbox b/test/Lombiq.UITestingToolbox index 13bf75ed8..7d8b14a1f 160000 --- a/test/Lombiq.UITestingToolbox +++ b/test/Lombiq.UITestingToolbox @@ -1 +1 @@ -Subproject commit 13bf75ed8d2e4af1ca4271955ee86472e1ce60e4 +Subproject commit 7d8b14a1f9826de59dbf5a334f43c1ea8421545d From 7cd0f5252816df75e0b4d2b89aaa6d5e99d571c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 11 Feb 2024 21:02:23 +0100 Subject: [PATCH 06/50] Increasing workflow timeout --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 926cdd8b0..c342374b7 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -15,7 +15,7 @@ jobs: with: parent-job-name: "root-solution-larger-runners" machine-types: "['buildjet-4vcpu-ubuntu-2204']" - timeout-minutes: 20 + timeout-minutes: 25 set-up-sql-server: "true" set-up-azurite: "true" ui-test-parallelism: 0 From 3b35410b4bbc7f3c6fd09feb3180f682bfce9b7e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 11 Feb 2024 21:29:27 +0100 Subject: [PATCH 07/50] Lombiq.Walkthroughs UI test log sections --- src/Modules/Lombiq.Walkthroughs | 2 +- test/Lombiq.UITestingToolbox | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index 82a07af02..e1d15024a 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit 82a07af02911b0ce65e44ad044887c0a93dbb435 +Subproject commit e1d15024a5f4295fe1ff88737c1045da6b96aca5 diff --git a/test/Lombiq.UITestingToolbox b/test/Lombiq.UITestingToolbox index 7d8b14a1f..d6d384912 160000 --- a/test/Lombiq.UITestingToolbox +++ b/test/Lombiq.UITestingToolbox @@ -1 +1 @@ -Subproject commit 7d8b14a1f9826de59dbf5a334f43c1ea8421545d +Subproject commit d6d3849121d7625adb1e50725450dadecfee328a From b83be1987b9d09b8535b8bce4c94de726cd97937 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 11 Feb 2024 21:29:54 +0100 Subject: [PATCH 08/50] Increasing process timeout --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index c342374b7..6498823d6 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -20,7 +20,7 @@ jobs: set-up-azurite: "true" ui-test-parallelism: 0 build-create-binary-log: "true" - dotnet-test-process-timeout: 360000 + dotnet-test-process-timeout: 420000 build-enable-nuget-caching: "true" build-enable-npm-caching: "true" From 21995cec0ab89f856d5f3438d2a7feae10ee7fba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 11 Feb 2024 21:32:22 +0100 Subject: [PATCH 09/50] Spelling --- src/Modules/Lombiq.Walkthroughs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index e1d15024a..f9e56fd3c 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit e1d15024a5f4295fe1ff88737c1045da6b96aca5 +Subproject commit f9e56fd3cb7ba0b164c070b0ec78b8fd19edcccd From bc3ebcd9d88c1f76cdf9958ba3690cb650549cc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 11 Feb 2024 22:27:18 +0100 Subject: [PATCH 10/50] Further increasing dotnet test process timeout --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 6498823d6..59050bae8 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -20,7 +20,7 @@ jobs: set-up-azurite: "true" ui-test-parallelism: 0 build-create-binary-log: "true" - dotnet-test-process-timeout: 420000 + dotnet-test-process-timeout: 480000 build-enable-nuget-caching: "true" build-enable-npm-caching: "true" From c647f847d285d6d0ce8810315334a262376f85c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 11 Feb 2024 22:32:07 +0100 Subject: [PATCH 11/50] Adding missing Theme.png for NuGet.TestTheme --- .../wwwroot/Theme.png | Bin 0 -> 17749 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 NuGetTest/src/Themes/Lombiq.OSOCE.NuGet.TestTheme/wwwroot/Theme.png diff --git a/NuGetTest/src/Themes/Lombiq.OSOCE.NuGet.TestTheme/wwwroot/Theme.png b/NuGetTest/src/Themes/Lombiq.OSOCE.NuGet.TestTheme/wwwroot/Theme.png new file mode 100644 index 0000000000000000000000000000000000000000..b1c3d790e2de201882de55cf9ac280d4577c1520 GIT binary patch literal 17749 zcmeIag;QMLlQ)dJC%C)2dvJGmcLoUV1a}J-f-?}@-QAtw?mkF@!@$FLcYpir*8A-H z7wl9`&Fyo#Kc`QhuDZATc2BgbvJ5H`0TKiR1ge~@q&fry6cz*oBr^is$B5BWwEo8r zq?@{oI7Ia{(dh>PV`#~eR$m+R4KoCd#^My1j{1p5#i0>|?>#pH! z?e1mfY6T%?>1=LACI>LHu~N4(v-J5oW+emx0Zn74sq3z*q$ptF3}7+)hlj-*;PN32 z0U;#n?P6x(VC7C`Ze?TVBusJD(L+IIXDLjf!>z=oa5Ir{u(5NqvhlOBvoW)=3$U{ZaIlg6$A{u$HCIb(0d+~~ z|5)pT5~i?qcXttBW%cs%V)5c+adx#~W#{MTXJzAH<=|lc;9z$1adJ2FW_EI;{1<|x zm79gDor}AjvlH1rh-T)_9`3>vADaIA762~)3G3wcA7=V67^}CL3oAPd+do_S7o(EW z|351L@Sogn?&?_R3X@o!cmqtmf-vUK)xqyIMO92iJ zHZCbHHgRcwz7NYw@rbcYa*J_uNQrUquyaU=bNx$J(%HfTVCCfgFImg~D=YCo%KqaH z0GE%IC9PcTJgqFHU7Z1B|F&%byZ>1i{{Ip0KV&WcXI;epM_JYnWmx|?-2Zae{~G%6 zpnop^({(?H|8#yUrw@;J{cvqxuIeZV2(c77Nij`tW6&nNx26^e&$SoLZ;s4c2t-J6 z6@-EZ<6=ZvX9}faI;8uUc88(*@oFd@ru_Vna4EGSFN7}ns~oB#m6-=oukRQ!m%crl zu-#YSn*(yUk{rLww&Tv@Ex}I``$qtzFOrgyMWJ=qK@=1eg`)9dAyH9L?iNX8ALJ$; z)dwNV3y1hY%!4A}5fj%@m$gLSphP)1SPJrYW&-jDuO4uFA`H3`Hr{kPNqFaf|4z=h zVlw8wqhXD;Kw3+myl0w`ol{aAQZ64!EjYqlE*Yw zwVuDXf}TX)8ChD8#fHhM62O6axQXb$@_XAcFv0J#@u+o((RjSRp9Pu$kPpS2e7-zj zmAiP68ku1@eDt>+{e#_u-USM1>K)=8*v6>Cn z8`Gd1%8&(j<2y`1_k;|Nrm3n7VW+Xl?stg1-Z8kby( zsI;V&J!#Hb@S}FS94HxSP5czaf=RXg=r^{iK0Tw8M9$cBMtB0&3w#DXhsmT#J+0XC zy0nOW4n&$3C=c5Wd5Xzu6>}eK61V6WB;C(ejEsj% z!lQO(z1^L(uSCGS3vWAWnQ_yu7p9MkmK4BG>&W2J;iraYar{ zRLLo-)dOyw*Ab?-PgS&{N`JQs+iS-xJU^e$CDdn}NZj4uy#si;WLG4J9(S6KZ*~S{ zzKT2b+@E~%zTTyEnZvH!yb8vz(&q_X%(n)MlzHR28U=DWZxP+FC+zjT)I(*jJus5^ z_+t%k2qJyeA~f3p&lDKQ+Z`MplaHJt3$>&|pJvpna+lFi0KWJapUKi;2m5EBEB)k> zsyag)O}gIoBvdW&EL@_~jG{BCLn7+4exz0`O|poO8YbRs2Yv-clxFHG3kH~>aFEl2 zA!tSgy8hhb@&(zVlK7vnD?XW`RpO+CWuRy(DvE*i7nA9&RO2ZGIiZv5uxIOiEWH2J zHw6o|Yx?k222%Z6kST7p&E|K5OG~i_8pn^frltXfSwZ6Ml@iQc09C?F{L}f-cSC56 zcrJnV)XKat9PUxV$*35F#dN`(r$76W#>OK4uIrQql%m`8qEDk4hrus@8h3zaB_|>( zX0jUOg`V;p`c1YGzmy2<*4f*nu?Ao;H?bNmV9FJk&$LmO?`!P$bQd1V0uAmal%FJZT*te>T)qR(ek7~O2|+SuD} zoc8g0h@H>xp2;^cE9{B1GtM_&-)#Lp{@N;6`dE<0bSP%%WU&Ch`|S;W^4*u^l5hjN zMma0GN9iQ;)5y$DP7Ti9(+ga_MUUD_{iBBEXSkH0ETJXJu@3(yS2`0G5-STJb*0bl z?c;3FHQVi#8~pIL7b_7Bt2%+_U{uHR{&Yt~f!D+I$#M%WjR+eYPAdks4y+gIX(G8q zWTExYyuL6De*8*<7wOqj6|aK#f2x4GkKGdzxb()P_IU1SuiPXv2!b6y1| z@4#}0*)^CMn#0`j{ zCk3PU)oOKIJ?K_ySAxItNXG}E5c{HupF0I4AEFFTJUk3UeNEhXX=|vv?WNw>1afCP z;RgQXhJ6tI!*%)d7G1Ns82CPVb0X|QwDxcoQOYniD?Ai6V(f#?`KvQ7ggB?9S5}k2`;zO_36%njUQra7maE*z$WbB23b&hi)ikRH?hM1ron>HL%i;Q|a+S~h5nFf`Ut)k zk0QsHVJQQ(c6(+NVj;YopPGFOWp0>`9dA2T)$Fn=9p9$G&!)@IRF)|H#B-Pc^f=aA0X`plz^F7EYvP;9QOLLPCF?Debr!z%|(|WS8CAS3z0$qwA&$xm2|sbw|i! z`nMU3l@x;U*)mLJNr!SVKf$#$V=7~@W#YL#n`Kq3^81<=2*MgjT1LoA<^f_*e7S{R zL28K>c+L;(&i)(kIai5IRz#DQfHvDAbI7JFWO=-_JMx~thX}40xCUOkrT}JF#g=>go zmRcStGu8}`5Hi_eKhp@Tr*cVTLPtdGtH-Wzd3{7YH2|#r$(mC7-B1zdafgAY+1g7H zT0Uhz{C&|+m1Z#7@3ISbrt=TW5;&dVbW;6QC=_J@HjtMkTNE8g{n^?75Aj)+r`d2~ zN3HLEVCvUam#Z#d({c4?ha69%6f#y|9(=TtKDomSmeB2OMQQ51I-Cr!a|_=`OORlA zqSqNkYNS04Ix_7*Bt=LKaFI_YN$Jjg-Y5P zoKcIK>LF3jrF3L{x-X9MOM`7c86z>hG)2z9D4TG*BG8UWF(G(@&Ngn zZ>Aka9yx26fLJEZF_;OaPrLy0Upe<_BeFl}@0XP|e7(6f6XGxI z@Z_Qb_seCs{Qz>4cv%ae3GI{$D@ck(awJ^zc9@3Oa=~Mx(=z>>eBsj z%N_z}w&Psx)dl>xpHpOdJWllXJJN|lL;kqm1$=WpehLnq8Owl$AEGn@f=io4`=2l@KQrY_OxH1L22^L4d`i@^{?fXu=_)A2cqb?9}av z8aZSgN=cRE`5spo%c&)7a^-b6{<7dE|K>VW^E0b!?h~d_;@R;6?QLV?F)j;Zp)a?` zX9Hq6y0d-x`;_s;02?_e@Byiabl`$;i$1CEZm%(y^X7PL-gy7cYEJj4 zv)%m<`>mi;4B76DPb29^l>5BAV3N|D>7395=Q|KOm|4lmmlc3>l%I9wT=@wTb2IK0 zHc&T&NtPi;v-M!OZCA|vysQeLA-rJcr)aYH2imelQc&Bap=NAZgsGd$?mXfCug6DP zi4XPWdQ{@G&Tb=2-ZpJ{g=9-Lr9Rk$wx-x3{venAmpJ>shu}_`WM*u5rW~2oos|ay z6DV+$iekU|4VH1Su+XxG)V;uVdN{%c~uUf z>hEUyZFjgErU;JCDUR#! zR1HHBY>~ig9HS}wCWkvG?)Mw7*A-AfeWF3rHlU9j0kOM|RI2E`%YZ_*6eBq=BOY4j ze!zhZJ|vWh^Km2C3Ly*;n?lG(Z^iF6-`#YX^i?y;`?5{s(S9f*i$<~3bsdCe6e^iC zhT^xIP$53Zio7)vwoF5L@Xnx!*9d_@lQR&l5&3o39IlYU+?4&jO-!$An2{BAsHCUz zH8K1HJ1Kx5bi{q+$x!bdEA5xKq^CAPLN;HB1#P0eDEy&}-!!vgcvPc>!<@}4+X1ew zQzl!1xa9QeHk++ukm2NC2eW?1=6-FylUG5_C^o*C-D!4V7b@l}Q5+i0sFlWN!Z`mw zUsv#Gsxh&!Vz6UH29mxCUk{uy_Yl%t%+GZGT?_b8w_|fkS;&5#(z7>|DDrX@j%X+0 ziO9H|B{>`K=0KF3G(EU05UVU9U~zg6uGOE^*WaqO#A!#nila7ou$u^>#t(WrrHTtU zrOr$<>2YJrVqWR+qEt5Oq~Zh-_B=C4_NK*qy}fbG8~qaH{;=}b*IpXMC+~Wy^Txcr;vT^q|~$V-$U~Y>L>?K~xVIx$o_r6K3DZbvp5V`0^MkUhTb6 zB@IiZVhqP~xq{MjfoxB>$$<0<>(XYVYT{>8w^nNfPWe-w?OM>VSqWk<3_Ww z^{};FqTD(546VXdwX(ePnJa zrlp-dj<5*6YJ4a~j>pWu)4MsWB4V2E{629;2Gzo>Lh^p^qt{XAB&bmctnti*I6EWp z1{ltXky4(<9t8aqkd!N*8LXm{kEQ!H&5ah#WSfNa$1PioUW7rOGB6@CBcX>VRs>hn9a8VgW|k+?VH3~V$!m9eBUkt`a<|C-$k&mj+j(eqQLkkax0C8 zGM<9*@^l#m1G+Zm>XraNUxE7DbuYAJ*oH}?QD~7!AtkV}**3M0iL0>`WiDfaOk9Gp zY2dP;08>AwY^0p0dP$EMpdk|_9`e59cOSb1l zdk33QX+6@rc5R?=Evn`^gPO_NNwht5@NybJRhKrHqXML@d(`h+JN_aiBMG;qlM6iC zd4{&%i83+m80r1>jNH^!v=wuHTfV;Lhtr~SYJrqd5h%lGvFo`YPj|@V8=wVeVD`wW z=hRdk3|10uu2q>GH=kP@3;#=tVbq06b59()7OmBIuj`71Nx$Ax3dpp2=fNg{$SA(ez`rSFrEW6ecJJNN4@IIg5KRbsPQTkU(Xm6{)kC zFngbATGdsy9G?`BYIY#HpN@bPGjS^Ras;Zg{!Osj2dKrdG@pBBZY|k%sobbFRG5pH z3|(=*fYRr6iX>|bF#Rjuc%B=!B3;aW8D3)69FFS+7vnw_g@8EhcO??+3u4H31meB! zXOR~7$xwg~SWvo3pvQR=#6vIR*=%kYBxP-|@a<$KXyzUdUfS?DD*3VWsdn~ZW54>& zs4oC?(8gL8hyQ?Hnx^|MqXv)CObVnj?CF-NaL{|+%25)+1v}Wr^IgBrm}`QTvE>$1 zR68>9KfT{$ngjQ1eV%k$tDJ@DHMj&&KnXcA)AF=l{Q0FoR_AV4TI1)VylWdka9sps zh4O)eVD$iIL?&mhWZExwTQ3{l?6F&0L0?H*1d$)lR9IOVV&*SYlg~bxC`=jftR4p= zseVuzM}e^;G>T#^zdT&n!9uPZu-;EYDr(G=p$|Pj!&gRK@n(C3jI+4mDW$pkMsagx zI>Yik6uQ5R7&l=qlR*X0D1M0w!v{6S&qcn_dZx6;^=-}wp*gtxz(LVw&JN}g*1%Y1 z!!nY-8)#!nbSFuEyuJd?p7uquxt&RBUM(OL7c!dN&2Y}vN=RwiYawn|DN0?FW~VdI zT@N6mcN(K_khHjKVtT*Tt+NOIiS<5Q4YcKO$CHoLzZtavCoga)`%USHylD!Yv4z3& zs{yT0tlw)fy5JTh7J0O;?_#P}8g>neMlH_W9m160l^t?Yj0EnhDvk@RmhGc5Krgcg zIvDhKAIgN<`X7^35le+f?%iJ^{q9Z$GSq|(VroTzjW=d?fKU?$EkFGIXHBi*$$=Y0gu#PY8GL{l^!8jvY# z|2Z1Jr~0>mzl?2arJo9lw=dSX^oYfNJ^#r<3CSLz)NZqxaP9tz529cJUx$|n#d*dE zbq&%{pX-ZEn-Q8GEIGosNF0&}Wv%^`Iu&>PAbJ^mte_n>Md#`<+kG%e=`0;oG{9lE z^LNMv(809QPK<_v{ZH=CM~`h-Mv;DS2~ZPHwH?3|CtCFCB_?8MNMvY3udL zK6E1oFK8Xk06iy7j2^1T{{_e1vxB%I-9LnYSsrM2wX_oSJg;RY4pli7NAE031!BTE zB*^I7z+T6&^C<9@he^K_q5p)*7=pSw)B@0^Puz|!p+%K2kJZ(5)Fz2-CY^^G+|8Mo zb&%y8)ej*G`{*4BT|`=LQGHy_?eXH+c3ZIrc6M*vu9<=qbLK730A47tc8Q7}&LS z5qTp1)X^~Ge|dzHT#8G2NU7SC#JX(2q>)Hj0uVIg74G1( z?}wv{N=Dtd+F(&M9E`D|4U|l1+??K8t<;$^>MvF@K>wxR2vqUX1n}YcW#kNs(ujOJ zes`tCaS}$znxn82LNa;3CH|#skg$A(A5E`8I;3F2+8<$(us3Z@?|l|;V~QR>Tt+Oq zTiw$grD9z~!Feada+w?1Vm-qwg0=I|j+wK7)6xA(tDGwof~vrAeLrAPXLaX@68I(; z=eHwFWb6q8{gcLgwv|NIO)rM9tKHhN--2{M6S51FXcKSMuVGGT3(iCg1MTt+(`Qbp z?)=yY;Va3A1F1?%ra!*_+gr+`{cp?*y}Wpk$<#t_ z?bP+Iu8oI*Jv!-nvlPW>oK5@wET1LKEZ~5VQZg=Pk1kfy1zhV8=uFUA8K)8g0Kk{#e^vNJ!Pk0cumK)7v780NbOf!%fja`Fx=~7(*TIYY9zBB4q=CYy zdH!JXZsTT6!MMw$Z}lFVqL@Yh@GXluFE+>2%Clx?DD{E5JUr6HMFc7B|cw|kwiFsa?iYHGaujN|J!`19m6U&zcC zoSj1zo5C3o^w+mXw4y_3y^;sA3FncwuB>7SkB_8ZlkM6onx^Luc7H>iY-v45U2hEJ zw;T4OpubpKk9&lClYLmFg|)tiic~Fxk;hkE@IJ~u?1+7H1!!@(v+&r2Xan0c2@=NL z4K7m(No3fcbHD9w3hW*iBU{!sPLO>M4nJ=;eI13b3)p0$f8fO9-4!M>^!yAa)EwG* zx%|>@Fg07XMn+`GRo;@qL*7R{Sde3^#`$_?V_$FfIrkV0V>X~79MH5S^Ve- zs+03b870q~w)2;Ric}fs&zslwZWb%=ep_(YO-q@|u3-XXpb7~CRntgw+OdoIDG%Zf zsoB;zz$JGzq%Or|$nUB~W-T2VZ=)G8`;zg!zxL;yb;(ul*#Jq=n=3-%!)3&XF>>?X11FiLibGk2|c23MV^v> zoNKm1n{2-Amys~}JO~RtEs$lqjeQfoL%bM69N^dMcDh%I@?5Ds$oqYh7=B*oqa}dG zycvJS&Vzy{40{zv5Hgu0d2lr*629!x&;Q>`(_Uo}y})K^(TDy8j|d#@iOwq`49Mr_|gt?JN1 z{i7VHe?~W6>0GjR314D<{2D(hni4az{nLNwo;=_q*|3`?)?y9ji9#74N*8{qqw%2r z$?b?}pv!TVR%brY3|eV-qa@&ROjOmY@(~RT4?DZNSx+FnS;KXvWcVet1kep9gR#D| zm*MuC-upYmc-{Z$s=&IK4-bI0P+>$kfio2`ksOvmf`^_+OIjt6C^aL^eZ9Z;l;lIO z!9x4|KpHuU!RhOM849ICBfSk~Qlx=)x>~`;$G7`~hU5S6n}~{rw?D$e?dAxVgEGD% z?vOCUA#ywR^J9R^So;$=uvKXOMqcK6Q`DwVuVWW)p^o}bQDi3Dn^Y>#q50VJ-F%&4 zVD&O>gHxUg;Yp52i6_Z#+8&v7z&F3ER^nf?9IZfrL$-jIwzV4Eq`{-gf?Rd9O1Jl? z2AwL2HV!nV?Z)O-A^V+c?*O_alZDe*#&lXYJ#DU1pJ>bXT~G1tfD&}l7w(4J z1o``LeB@dTeROgztlH?Al9!hhJt08cx`^i1@i*#frc7}*+Uxai+|tw)2m{_g+I24m ziiy;L`n#S&-*_H6hm>!w*Hr4fEMgBL==~m^@GPTz&0p6E-0ioCBkx%UhWA&!L1W97 zSw$eQ+d&a4<98Uic9AAL z-|zibcSshEt=6AAjav`jZ$GWq-OuuCG7yK1<@JOK+qHe~MB8uKKaNpx!yd~337cJT zBBcLXt5`Nd_zwPKu8pIZV0&vj2lLyeGfwWR6Dd|03;%QkgFuU<4lR@^2)nF@SR(cp za}oLtPPhIy0avTW^uA9Pmyzqo!?npO`IXeTWiMzJH+yYSOeTaS=rw~C4O?Ma#?E&~ z+%DF{z2gBTs?7GuPiG|yv-f(5j-)+jS+B~g)^8Q^+O0}KI>Cw* zhOOrb>s;o9inu_b@|ZMsoWa66O*xN`9RQAE@Q=XcCCjdPJB%Pe;VEPd}_nm3~=^UTI{+W?W{KdO2z#?;s-uWHk*x1J0Wq zsMmM^=!vfrZq|L~TmxCOO8NrXVGQx?%{tDRlpRntw04U*0gzAgx1!U$h1XqVtgtD6NQ{n4%8`PKm_hCticA?IiC0X!1}Mg@x5#nS=v*H3;c65o-Z` zo>*3joP^ty0WUO*wz0c89TW=owEe+E^4bmfYE0|brb>x z*#xq5a;Oqm<}3#OOxYh80Om=j3YU7<(ibi*(uf%?CfX;S?X(Kqxmr#n+VUKD{s7gT ztb2WC2rs|hlL;0^Q?RZP=XW4^PP9*m+{&ild}XxBJ>ypT#YUfC;Gkm<(Bv-P<1ZGX zDYK}#h`qdUOl8y|{Pcp}R~#36E&IYP&+o4ezq;zANCZZakNny6%tjDmwUgGK?0bhT z%b08hOMS0bGZI~n>bG}X=H}wN&A|oAjjKto{H<(I{!Cx~P?*?M!IPPj3z^dXHi}sY zLKivxwD3zMg$I}MC3`)irpXyQ)!%sa7s+V=QW5Kf8#yN!OB&S|X0Z@-!hV21>HW;l zWPHtX=Bd<|4qc+!WrqIx{Km`Y<$|q$TN=!YQ#DtuLFcF+%tIquk260Uqiiwu{BD+% zBxbPG5RgHBoxRBf$&M__0)~|ELzk+C>8B8}3p#Yzj2I#fjBOlnm@Ty75PA10ZiIK< zG5>0pD6)#yHch5T@E4_jvi_2KO-k*B^%wS?EC1rq3AIAmC33So@ke0aoOp&CTZ%YH z8cF#~*`l0;!9d?)w+efn5f~g#YiPUPD&ktC;rP3evU#*JX#dU4cD*y+{o03PXK|>G zQ-;m*#KPNk!_8Y$pmZz8DJ6^;Z*cLOMZCPYYY}vwLVY44V};R=!whNd8e@xWkw(Od zhwM~kPBiOfAEuR7wD|LuIq{hL*9wBKVrC`f9_ivaKo$A&=uaie77L>`H(}ZlC9^=K ziaiOx7~e+U>NT}^8o|o>;DwrX1ci*iM5Y?px;d-5pugr9QcZi{3G zX{(xH^yQDA!`E(NVFaK&roNO;;#s)NSq*DEykRHG`H-~wQ4mmRGXyFDFj%ypy*zB= zb>8m3d0z4=Z;1}?_D--S4(GZCi0kfRQdn`1pF zlRCu8VQ{NospF1CT}H{3d5K~;-cAMDcOB8vH1?R=o7ak+ZJV%->#_K3E)hTa9gUGK z492i6pqP@m)2Pu9uzfISNyP6aZC$ToxBh^++8wag^zqP3v(|DJ6MueWv5wDrrp*wF z6TfD@#jBx)krQIi0nMt@Moxjmva>FwfJvx_GuMYR`F=>tm%DkKUug-B4b%0E&X5@?#evad4}-7hF`9_LVg z?oj4Q$bODUxx{}tNK!Zw@!!5p=7u)iF|54@<%w-^A~zAZ_hP%cJ|visTxPf zR?G%-C1fyg2@-)F%lqFKI!x}T!hWJ+UdRt*!;0Dhq>R3tCiiaDdrDLqa-xsSchO;E z1C9L5YSYA5=L@hrDQ<30aIHl1!d_&AqNvKU6gUdbW__pvbD9W=83nHI3ZJgW Kr zqgFN2_rm+YMNFgvIGTIygj&lSY$GegkDwE$R7CpNY&XBJ43sU8AsgrPbV;=qtg*oW z1JnD;j5@GCn{TrdLx4&CJ4zA{rH2~ONzngh8mp7b9Yf@YFmaj#cLez{#ke+r1|+^@ zc0m!mpe(~^-ltS#CyY&_@3$*GVcud`zE-Q51fy*?s`w?faUk}~Pg(dp&c0#y|aQYAv=j7BOqVDTJ~I948=LZn00F znK>FqWzesMnUN}i`l}6g)%)${p*Co0q;#nP?m6K+ET-zbza%05vxxTC^mK1Zipapu z@L219HC*XZGZB{lki}6s@elBu_+TVKBgeskH8!c9+Ok6&;X9oDN<-2H3#4%5b_9+oZzCWxs*h!80u*8!laoa{#p4Z+;BibzE@XfP~F8e6$=E0zdKIEFF;B za<_7;3sCL&yHFT+ze65)|Fw+B3mCdXxBr!ylbL{$0qOQDAkw5KC+=7zJ6t{4>iU6q zWDf|dQ1dt#yytoZG?>9$>HMRh`)Q4=xKg4bD{vrJtYo~Pbh{4AiF64Gbk%`7Bf|m2j|)2zL&XLUS&c^_3;kR<-K+I#PbSd>!$-C zdKk%98JS)yOCrkTe>r$Mvlailrc`IUD_FYNgU>=>ezTOqx>tsFQcYMpXm57E`?A!} zKuE-(Q4Q`)w)5$>!h1h0*p{miza7;fLfJxkjEsfTDD%Y9$_BS5QXsXunv>xv_v{lf z@{yu=N;mVYg}-3u6IeVBUx;A!jV$hrAEBm41Z4_td4$jnmrOFZ=9xE)#&oSn=X!cu zx=^mi+IFc}K*XRPGay1F`lBiysHbyEEA1`@nr=#hhu`w{L<)R5Vl7>5VeyT3N=#J- zVdCQ?9_N7~l_>>wn>z^2iWLVhF9nH2{hv?>?wn|>>=Kuc-oCL*4BM5+ZPt@w8&MwK zKC;>G&`pB>u-XdMLS6>mC`k%bj(5LVzH%tIy)yp(s1Duf&BN{9nlpr=AFa~%LZ2>LttRlXHS;Ok|6+fyK zDf=zPf#!ylJOgT^!OwtY0X*^jB;9U9(+K7Z(%1HlBVW9?&NkTJ+2Qg1@+`w8hc)okV~oe`*I8gn1R>!Ckl0 zQk@RS>71=ZH$CHp^ts zlI}ScS`dmS@ml2UHQ$1~;(`ET1`6ESe)dbCLO3%8B(}Va11CFo2XY1n=}HHpP5oar z*5ZOm-PbiQ&(Ffj!qUR5eC1eJUZ=gB`7U~;ol_!Me#jyr(np~+41gwwo3{f~ z0J9i4cC>97(`N6P4W)U8Dug==Ej%O}9a7CTla=MmQa?5;7n7f5cM^=UFo+Fc>(nq2 zLP)c`evO|miCfy%@>J-oPoIpZfx7Y4=CG3uyJAq1GS_Iy(1Urf${;My}1T;nHS|endK$WT!8|2=i{Zo0*gaNGbx`^aj7pOC7{t_x%`CpO#{VF z1Ko$^^wsJmV&Yyn(3UpASXP3#OeRukErS5UvIi0QtLezS2SPeXyUv|W`)Z{appv4p z_IwGFt)5dAT-2yvEzQi9YaUDxUN>zFD>TcAz@n(%9iQo6>VM``@T;A0AWaV77ywAR zHl3|?pHEEn9(4&~;NUR6$QGg~QitYGVu76;H@i^fsTT0xQwVMIq+N^! zLUSS)Jum>ZZWBl_G8r=BhD6hOd|{zBDnQ>wUpfPZPH$69O@p>nPoxnROP~i3PPZix zc05%88d2Q5QiYr{(l!Zy%a!k+iS2@5+X$;5Or`UkE%e$;a+?dCdZWrtmE7aU5c$ z(P<9p1?Eix2%hpUdlt~Bs{$|Y9t8qHY8ikb3FRE6%f4-M{;SC>_H;5nE9q6#Ew~|pW zhOtAPpN^|HX{?FG=kzK}R}5P?o%*h6M8scSQ?riF zPYc73VUW!*2Ue|frrHzjBp(N|UzeB_bTC37k?%6L^H&UIRRa|Kw- z1+ohxi0C@R2r=GEzd9tQc&L`(K^;#lUIpK^J~ua4|M8YGs(g|$Fj>s<1%UQbsn4X; z%)|kq-|q@PS5^3Smd{j>dJTd4eRb|AuCxu6xs%3!1hh^5?6m-&ZPe6!X%5yCe0KA= zsnOdOw-;XUz@}c88GD#(wlmwzcr{8>GukPy)=|4Ep043XGm&qq(mdA{mKXX zN%TkTl&F(r@cH*jja}%lC8wgDWe1Zr&+iX9pu0aWa7$uFer{c!z;Hx8To0SEd+qwS z)ZVu9iI<<+CF<$tO%2~Fwp*?}cOBrG+te-}Y-@}bx}nZ(I<4QC)o+CWFBQ!mUH6q| zdR_NdfEFyP?pNPnfcqWjyCztE(RPM;6}I95nJEMDyFIHENcD49iS{%W;LvxSy_Oki zJ;^t*SG+3s@UW?!!FRc^KGpy2?jG3tR+#Qn)LjI?y)V!=pjSKAe-dVaS?_1N1F=7P z=D}BpzCht;%p;qe$}jr`Nrl7R)!kJ*#P4<2x1x7{*CzerJM_}z*umBTEeuBm{GIRR zVseFsmA(-yKgy}g{q|j$xRZw z^L>eEL7C2DYJ@cUjc`FGaH>rvdA6C@p4%~EX6p$mnFo8X2G#AI@l5cWzGsZo119Ni zGGtEDd8dE-o%S%9T9jDGNsky<395q!+N0eSdN~LKoLCA(^sGP?qe=1Xnu$ljgoJ~c zc+0Qmeh#uTY1IoEWcH||#sqgDC1vErR%RNA|#0_dE&Iv1Xq*@2 z#x-lvxV!b9%bJ-M<3IJfS4qi&G*obhl;gN8tzVtI|LIjNG{9wTruzT%tp4{}+W*$h z`oB~EwYm3yt?|Fs_@5fT|JOJE*EjyxH=<-|cithomBjkv4>BJA`P&jXDP_rOanq3h E1FI-EZvX%Q literal 0 HcmV?d00001 From 13ad25dbe6f5b6b2c0cd3f1c37e3de1fda629a44 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 11 Feb 2024 22:49:57 +0100 Subject: [PATCH 12/50] Updating NuGetTest solution too --- .../Lombiq.OSOCE.NuGet.Web.csproj | 6 ++-- .../Lombiq.OSOCE.NuGet.Tests.UI.csproj | 4 +-- .../ModuleTests/BehaviorWalkthroughsTests.cs | 31 ++++++++++++++++--- src/Modules/Lombiq.Walkthroughs | 2 +- .../ModuleTests/BehaviorWalkthroughsTests.cs | 3 +- 5 files changed, 34 insertions(+), 12 deletions(-) diff --git a/NuGetTest/src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj b/NuGetTest/src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj index f74058fac..f7582ea77 100644 --- a/NuGetTest/src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj +++ b/NuGetTest/src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj @@ -48,12 +48,12 @@ - - + + - + diff --git a/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Lombiq.OSOCE.NuGet.Tests.UI.csproj b/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Lombiq.OSOCE.NuGet.Tests.UI.csproj index e706ea885..257ea3ea6 100644 --- a/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Lombiq.OSOCE.NuGet.Tests.UI.csproj +++ b/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Lombiq.OSOCE.NuGet.Tests.UI.csproj @@ -42,9 +42,9 @@ - + - + runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index 91d1ce5fb..e7deba650 100644 --- a/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -1,6 +1,11 @@ +using Lombiq.Tests.UI.Extensions; +using Lombiq.Tests.UI.Services; using Lombiq.Walkthroughs.Tests.UI.Extensions; +using OpenQA.Selenium; +using Shouldly; using System; using System.IO; +using System.Linq; using System.Threading.Tasks; using Xunit; using Xunit.Abstractions; @@ -18,9 +23,25 @@ public BehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) public Task WalkthroughsShouldWorkCorrectly() => ExecuteTestAsync( context => context.RunSetupAndTestWalkthroughsBehaviorAsync(), - // Could be removed if https://github.com/shepherd-pro/shepherd/issues/2555 is fixed. - changeConfiguration: configuration => configuration.HtmlValidationConfiguration.HtmlValidationOptions = - configuration.HtmlValidationConfiguration.HtmlValidationOptions - .CloneWith(validationOptions => validationOptions.ConfigPath = - Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "BehaviorWalkthroughsTests.htmlvalidate.json"))); + changeConfiguration: configuration => + { + configuration.HtmlValidationConfiguration.HtmlValidationOptions = + configuration.HtmlValidationConfiguration.HtmlValidationOptions + .CloneWith(validationOptions => validationOptions.ConfigPath = + Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "BehaviorWalkthroughsTests.htmlvalidate.json")); + + // Once the linked issues are fixed, the custom browser log assertion can be removed completely. + configuration.AssertBrowserLog = logEntries => logEntries.ShouldNotContain( + logEntry => IsValidLogEntry(logEntry), + logEntries.Where(IsValidLogEntry).ToFormattedString()); + }); + + private static bool IsValidLogEntry(LogEntry logEntry) => + OrchardCoreUITestExecutorConfiguration.IsValidBrowserLogEntry(logEntry) && + // See https://github.com/OrchardCMS/OrchardCore/issues/15301. + !(logEntry.Message.ContainsOrdinalIgnoreCase("/OrchardCore.Resources/Scripts/jquery.js?v=") && + logEntry.Message.ContainsOrdinalIgnoreCase("3128:6 Uncaught")) && + // See https://github.com/OrchardCMS/OrchardCore/issues/14598. This error has multiple variations, so targeting + // the lowest common denominator with the file name. + !logEntry.Message.ContainsOrdinalIgnoreCase("/monaco/IStandaloneEditorConstructionOptions.json"); } diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index f9e56fd3c..096433d2d 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit f9e56fd3cb7ba0b164c070b0ec78b8fd19edcccd +Subproject commit 096433d2d25f5b4bd1e5c33b86d65b0c1ac107c8 diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index 9c96d939d..00e4b2263 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -31,6 +31,7 @@ public Task WalkthroughsShouldWorkCorrectly() => .CloneWith(validationOptions => validationOptions.ConfigPath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "BehaviorWalkthroughsTests.htmlvalidate.json")); + // Once the linked issues are fixed, the custom browser log assertion can be removed completely. configuration.AssertBrowserLog = logEntries => logEntries.ShouldNotContain( logEntry => IsValidLogEntry(logEntry), logEntries.Where(IsValidLogEntry).ToFormattedString()); @@ -42,6 +43,6 @@ private static bool IsValidLogEntry(LogEntry logEntry) => !(logEntry.Message.ContainsOrdinalIgnoreCase("/OrchardCore.Resources/Scripts/jquery.js?v=") && logEntry.Message.ContainsOrdinalIgnoreCase("3128:6 Uncaught")) && // See https://github.com/OrchardCMS/OrchardCore/issues/14598. This error has multiple variations, so targeting - // the lower common denominator with the file name. + // the lowest common denominator with the file name. !logEntry.Message.ContainsOrdinalIgnoreCase("/monaco/IStandaloneEditorConstructionOptions.json"); } From f51112a0e0ac6d9c40adfe3b7680ba59a5935df5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:14:13 +0100 Subject: [PATCH 13/50] Temporarily enabling parallel builds --- .github/workflows/build-and-test.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 59050bae8..d2b014f55 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -23,6 +23,7 @@ jobs: dotnet-test-process-timeout: 480000 build-enable-nuget-caching: "true" build-enable-npm-caching: "true" + cancel-in-progress-for-this-pr: "false" build-and-test-standard-runners: # Since dev builds are not awaited by anyone, they can run on the slower free runners. @@ -45,6 +46,7 @@ jobs: build-directory: NuGetTest timeout-minutes: 15 dotnet-test-process-timeout: 360000 + cancel-in-progress-for-this-pr: "false" spelling: name: Spelling @@ -63,12 +65,14 @@ jobs: lombiq-lgha:dictionaries/Xml.txt lombiq-lgha:dictionaries/Lombiq.people.txt lombiq-lgha:dictionaries/Security.txt + cancel-in-progress-for-this-pr: "false" powershell-static-code-analysis: name: PowerShell Static Code Analysis uses: Lombiq/PowerShell-Analyzers/.github/workflows/static-code-analysis.yml@dev with: machine-types: '["ubuntu-22.04"]' + cancel-in-progress-for-this-pr: "false" yaml-linting: name: YAML Linting From 6dd25c42fa8107bf75101591ab7d32451ad1834b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:16:01 +0100 Subject: [PATCH 14/50] Re-adding mistakenly removed comments --- .../Tests/ModuleTests/BehaviorWalkthroughsTests.cs | 1 + .../Tests/ModuleTests/BehaviorWalkthroughsTests.cs | 1 + 2 files changed, 2 insertions(+) diff --git a/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index e7deba650..e66dec625 100644 --- a/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -25,6 +25,7 @@ public Task WalkthroughsShouldWorkCorrectly() => context => context.RunSetupAndTestWalkthroughsBehaviorAsync(), changeConfiguration: configuration => { + // Could be removed if https://github.com/shepherd-pro/shepherd/issues/2555 is fixed. configuration.HtmlValidationConfiguration.HtmlValidationOptions = configuration.HtmlValidationConfiguration.HtmlValidationOptions .CloneWith(validationOptions => validationOptions.ConfigPath = diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index 00e4b2263..4ed7e1ad1 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -26,6 +26,7 @@ public Task WalkthroughsShouldWorkCorrectly() => // Could be removed if https://github.com/shepherd-pro/shepherd/issues/2555 is fixed. changeConfiguration: configuration => { + // Could be removed if https://github.com/shepherd-pro/shepherd/issues/2555 is fixed. configuration.HtmlValidationConfiguration.HtmlValidationOptions = configuration.HtmlValidationConfiguration.HtmlValidationOptions .CloneWith(validationOptions => validationOptions.ConfigPath = From 135aafc78b82ceb0f434be7830109d5505949369 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:21:29 +0100 Subject: [PATCH 15/50] Removing orphaned elements in Lombiq.Walkthroughs --- src/Modules/Lombiq.Walkthroughs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index 096433d2d..854f8bf71 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit 096433d2d25f5b4bd1e5c33b86d65b0c1ac107c8 +Subproject commit 854f8bf711c408840ecf9448f517ab4b30f77f61 From 0517125777301b0911fecf35cab25cae375b09f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:22:07 +0100 Subject: [PATCH 16/50] Temporarily renaming test class to see if it helps performance --- ...viorWalkthroughsTests.cs => ABehaviorWalkthroughsTests.cs} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/{BehaviorWalkthroughsTests.cs => ABehaviorWalkthroughsTests.cs} (94%) diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs similarity index 94% rename from test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs rename to test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs index 4ed7e1ad1..9f4e7e690 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs @@ -12,9 +12,9 @@ namespace Lombiq.OSOCE.Tests.UI.Tests.ModuleTests; -public class BehaviorWalkthroughsTests : UITestBase +public class ABehaviorWalkthroughsTests : UITestBase { - public BehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) + public ABehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) : base(testOutputHelper) { } From 5209928f55a3588b26a6bdffccaabaabb115ae68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:22:36 +0100 Subject: [PATCH 17/50] Dummy change to kick off build --- .../Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt new file mode 100644 index 000000000..e69de29bb From abe44ff0c1fa3a5d8d07c1272483e71f4cb6fd3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:23:07 +0100 Subject: [PATCH 18/50] Revert "Dummy change to kick off build" This reverts commit 5209928f55a3588b26a6bdffccaabaabb115ae68. --- .../Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt deleted file mode 100644 index e69de29bb..000000000 From 9e1020cb5998a13d87ef46aaba44d284f203dcca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:28:57 +0100 Subject: [PATCH 19/50] Spelling --- .../Tests/ModuleTests/ABehaviorWalkthroughsTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs index 9f4e7e690..0b4facf8d 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs @@ -12,9 +12,9 @@ namespace Lombiq.OSOCE.Tests.UI.Tests.ModuleTests; -public class ABehaviorWalkthroughsTests : UITestBase +public class ABehaviorWalkthroughsTests : UITestBase // #spell-check-ignore-line { - public ABehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) + public ABehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) // #spell-check-ignore-line : base(testOutputHelper) { } From b79cbfec94333077f7dce777edc1fd189ad40061 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:29:22 +0100 Subject: [PATCH 20/50] Dummy change to kick off build --- .../Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt new file mode 100644 index 000000000..e69de29bb From fe90f14ffccc06c336a7d68f943d4d6811e7a9ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:29:31 +0100 Subject: [PATCH 21/50] Revert "Dummy change to kick off build" This reverts commit b79cbfec94333077f7dce777edc1fd189ad40061. --- .../Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt deleted file mode 100644 index e69de29bb..000000000 From 4489acf22b78f61b7db1d1214dfb229647e456e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:31:11 +0100 Subject: [PATCH 22/50] Temporarily disabling Spelling workflow --- .github/workflows/build-and-test.yml | 30 ------------------- .../ModuleTests/ABehaviorWalkthroughsTests.cs | 4 +-- 2 files changed, 2 insertions(+), 32 deletions(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index d2b014f55..0e9c67911 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -48,25 +48,6 @@ jobs: dotnet-test-process-timeout: 360000 cancel-in-progress-for-this-pr: "false" - spelling: - name: Spelling - uses: Lombiq/GitHub-Actions/.github/workflows/spelling.yml@dev - with: - additional-dictionaries: | - cspell:csharp/csharp.txt - cspell:css/dict/css.txt - cspell:fullstack/dict/fullstack.txt - cspell:html-symbol-entities/entities.txt - cspell:html/dict/html.txt - cspell:html/src/svg.txt - cspell:node/dict/node.txt - cspell:npm/dict/npm.txt - lombiq-lgha:dictionaries/Liquid.txt - lombiq-lgha:dictionaries/Xml.txt - lombiq-lgha:dictionaries/Lombiq.people.txt - lombiq-lgha:dictionaries/Security.txt - cancel-in-progress-for-this-pr: "false" - powershell-static-code-analysis: name: PowerShell Static Code Analysis uses: Lombiq/PowerShell-Analyzers/.github/workflows/static-code-analysis.yml@dev @@ -81,17 +62,6 @@ jobs: config-file-path: tools/Lombiq.GitHub.Actions/.trunk/configs/.yamllint.yaml search-path: . - post-pull-request-checks-automation: - name: Post Pull Request Checks Automation - needs: [build-and-test-larger-runners, build-and-test-nuget-test, spelling, powershell-static-code-analysis] - if: github.event.pull_request != '' - uses: Lombiq/GitHub-Actions/.github/workflows/post-pull-request-checks-automation.yml@dev - secrets: - JIRA_BASE_URL: ${{ secrets.DEFAULT_JIRA_BASE_URL }} - JIRA_USER_EMAIL: ${{ secrets.DEFAULT_JIRA_USER_EMAIL }} - JIRA_API_TOKEN: ${{ secrets.DEFAULT_JIRA_API_TOKEN }} - MERGE_TOKEN: ${{ secrets.LOMBIQBOT_GITHUB_PERSONAL_ACCESS_TOKEN }} - add-windows-build-warning-label: name: Add Windows Build Warning Label runs-on: ubuntu-22.04 diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs index 0b4facf8d..9f4e7e690 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs @@ -12,9 +12,9 @@ namespace Lombiq.OSOCE.Tests.UI.Tests.ModuleTests; -public class ABehaviorWalkthroughsTests : UITestBase // #spell-check-ignore-line +public class ABehaviorWalkthroughsTests : UITestBase { - public ABehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) // #spell-check-ignore-line + public ABehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) : base(testOutputHelper) { } From d773726acd0924ba97ccc255c2223ac381efd269 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:31:45 +0100 Subject: [PATCH 23/50] Dummy change to kick off build --- .../Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt new file mode 100644 index 000000000..e69de29bb From b95046be56422656970cb9794b2b3d52b7d5b6bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:31:54 +0100 Subject: [PATCH 24/50] Revert "Dummy change to kick off build" This reverts commit d773726acd0924ba97ccc255c2223ac381efd269. --- .../Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/New Text Document.txt deleted file mode 100644 index e69de29bb..000000000 From 127abfdf439571d4687793adab09e4a1ebb5f977 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:50:26 +0100 Subject: [PATCH 25/50] Temporarily removing NuGetTest build too --- .github/workflows/build-and-test.yml | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 0e9c67911..437c376f0 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -38,16 +38,6 @@ jobs: build-create-binary-log: "true" dotnet-test-process-timeout: 720000 - build-and-test-nuget-test: - name: Build and Test - NuGetTest solution - uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev - with: - parent-job-name: nuget-solution - build-directory: NuGetTest - timeout-minutes: 15 - dotnet-test-process-timeout: 360000 - cancel-in-progress-for-this-pr: "false" - powershell-static-code-analysis: name: PowerShell Static Code Analysis uses: Lombiq/PowerShell-Analyzers/.github/workflows/static-code-analysis.yml@dev @@ -61,19 +51,3 @@ jobs: with: config-file-path: tools/Lombiq.GitHub.Actions/.trunk/configs/.yamllint.yaml search-path: . - - add-windows-build-warning-label: - name: Add Windows Build Warning Label - runs-on: ubuntu-22.04 - timeout-minutes: 2 - needs: [build-and-test-larger-runners, build-and-test-nuget-test, powershell-static-code-analysis] - steps: - - name: Add Windows Build Warning Label - # v2.0.0 - uses: buildsville/add-remove-label@eeae411a9be2e173f2420e1644514edbecc4e835 - with: - # The token is necessary to be able to add the label even if the workflow is triggered by a pull request coming - # from a fork. - token: ${{ secrets.LOMBIQBOT_GITHUB_PERSONAL_ACCESS_TOKEN }} - labels: requires-windows-build - type: add From 269e1599a96e593e3df52df9f5c13b87a59cc224 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:52:32 +0100 Subject: [PATCH 26/50] Dummy change to kick off build again --- .github/workflows/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 .github/workflows/New Text Document.txt diff --git a/.github/workflows/New Text Document.txt b/.github/workflows/New Text Document.txt new file mode 100644 index 000000000..e69de29bb From 7ab5024a665ca5f9743a6cb9d9caaa822bbd6dc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:52:46 +0100 Subject: [PATCH 27/50] Revert "Dummy change to kick off build again" This reverts commit 269e1599a96e593e3df52df9f5c13b87a59cc224. --- .github/workflows/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .github/workflows/New Text Document.txt diff --git a/.github/workflows/New Text Document.txt b/.github/workflows/New Text Document.txt deleted file mode 100644 index e69de29bb..000000000 From 31e5d909b7f25507894da4b3777d0fcb7eced76c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:54:20 +0100 Subject: [PATCH 28/50] Revert "Temporarily renaming test class to see if it helps performance" This reverts commit 0517125777301b0911fecf35cab25cae375b09f9. --- ...aviorWalkthroughsTests.cs => BehaviorWalkthroughsTests.cs} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/{ABehaviorWalkthroughsTests.cs => BehaviorWalkthroughsTests.cs} (94%) diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs similarity index 94% rename from test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs rename to test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index 9f4e7e690..4ed7e1ad1 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/ABehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -12,9 +12,9 @@ namespace Lombiq.OSOCE.Tests.UI.Tests.ModuleTests; -public class ABehaviorWalkthroughsTests : UITestBase +public class BehaviorWalkthroughsTests : UITestBase { - public ABehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) + public BehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) : base(testOutputHelper) { } From 1650165416e7943d7995c7a24fd224c9166a2067 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 14:59:21 +0100 Subject: [PATCH 29/50] Trying to run BehaviorWalkthroughsTests in the beginning with a name defined in a Collection attribute instead --- .github/workflows/build-and-test.yml | 59 +++++++++++++------ .../ModuleTests/BehaviorWalkthroughsTests.cs | 1 + 2 files changed, 43 insertions(+), 17 deletions(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 437c376f0..4b9385106 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -8,7 +8,7 @@ on: - dev jobs: - build-and-test-larger-runners: + build-and-test-larger-runners1: if: github.ref_name != github.event.repository.default_branch name: Build and Test - root solution (larger runners) uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev @@ -25,29 +25,54 @@ jobs: build-enable-npm-caching: "true" cancel-in-progress-for-this-pr: "false" - build-and-test-standard-runners: - # Since dev builds are not awaited by anyone, they can run on the slower free runners. - if: github.ref_name == github.event.repository.default_branch - name: Build and Test - root solution (standard runners) + build-and-test-larger-runners2: + if: github.ref_name != github.event.repository.default_branch + name: Build and Test - root solution (larger runners) uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: - parent-job-name: "root-solution-standard-runners" - timeout-minutes: 50 + parent-job-name: "root-solution-larger-runners" + machine-types: "['buildjet-4vcpu-ubuntu-2204']" + timeout-minutes: 25 set-up-sql-server: "true" set-up-azurite: "true" + ui-test-parallelism: 0 build-create-binary-log: "true" - dotnet-test-process-timeout: 720000 + dotnet-test-process-timeout: 480000 + build-enable-nuget-caching: "true" + build-enable-npm-caching: "true" + cancel-in-progress-for-this-pr: "false" - powershell-static-code-analysis: - name: PowerShell Static Code Analysis - uses: Lombiq/PowerShell-Analyzers/.github/workflows/static-code-analysis.yml@dev + build-and-test-larger-runners3: + if: github.ref_name != github.event.repository.default_branch + name: Build and Test - root solution (larger runners) + uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: - machine-types: '["ubuntu-22.04"]' + parent-job-name: "root-solution-larger-runners" + machine-types: "['buildjet-4vcpu-ubuntu-2204']" + timeout-minutes: 25 + set-up-sql-server: "true" + set-up-azurite: "true" + ui-test-parallelism: 0 + build-create-binary-log: "true" + dotnet-test-process-timeout: 480000 + build-enable-nuget-caching: "true" + build-enable-npm-caching: "true" cancel-in-progress-for-this-pr: "false" - yaml-linting: - name: YAML Linting - uses: Lombiq/GitHub-Actions/.github/workflows/yaml-lint.yml@issue/OSOE-188 + build-and-test-larger-runners4: + if: github.ref_name != github.event.repository.default_branch + name: Build and Test - root solution (larger runners) + uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: - config-file-path: tools/Lombiq.GitHub.Actions/.trunk/configs/.yamllint.yaml - search-path: . + parent-job-name: "root-solution-larger-runners" + machine-types: "['buildjet-4vcpu-ubuntu-2204']" + timeout-minutes: 25 + set-up-sql-server: "true" + set-up-azurite: "true" + ui-test-parallelism: 0 + build-create-binary-log: "true" + dotnet-test-process-timeout: 480000 + build-enable-nuget-caching: "true" + build-enable-npm-caching: "true" + cancel-in-progress-for-this-pr: "false" + diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index 4ed7e1ad1..ad161ec77 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -12,6 +12,7 @@ namespace Lombiq.OSOCE.Tests.UI.Tests.ModuleTests; +[Collection("ABehaviorWalkthroughsTests")] public class BehaviorWalkthroughsTests : UITestBase { public BehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) From 6ce2190b29e8d70a1eaf99f62bf6032294d74fc0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 15:01:06 +0100 Subject: [PATCH 30/50] Dummy change to kick off build again --- .github/workflows/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 .github/workflows/New Text Document.txt diff --git a/.github/workflows/New Text Document.txt b/.github/workflows/New Text Document.txt new file mode 100644 index 000000000..e69de29bb From 5ead90d70ba2d0decfb21c326e8f745ba5633157 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 15:01:15 +0100 Subject: [PATCH 31/50] Revert "Dummy change to kick off build again" This reverts commit 6ce2190b29e8d70a1eaf99f62bf6032294d74fc0. --- .github/workflows/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .github/workflows/New Text Document.txt diff --git a/.github/workflows/New Text Document.txt b/.github/workflows/New Text Document.txt deleted file mode 100644 index e69de29bb..000000000 From b8a657f9dd4fa2852e3f58995bb12474c556246b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 15:03:44 +0100 Subject: [PATCH 32/50] Setting parent job names too --- .github/workflows/build-and-test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 4b9385106..443e88c89 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -13,7 +13,7 @@ jobs: name: Build and Test - root solution (larger runners) uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: - parent-job-name: "root-solution-larger-runners" + parent-job-name: "root-solution-larger-runners1" machine-types: "['buildjet-4vcpu-ubuntu-2204']" timeout-minutes: 25 set-up-sql-server: "true" @@ -30,7 +30,7 @@ jobs: name: Build and Test - root solution (larger runners) uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: - parent-job-name: "root-solution-larger-runners" + parent-job-name: "root-solution-larger-runners2" machine-types: "['buildjet-4vcpu-ubuntu-2204']" timeout-minutes: 25 set-up-sql-server: "true" @@ -47,7 +47,7 @@ jobs: name: Build and Test - root solution (larger runners) uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: - parent-job-name: "root-solution-larger-runners" + parent-job-name: "root-solution-larger-runners3" machine-types: "['buildjet-4vcpu-ubuntu-2204']" timeout-minutes: 25 set-up-sql-server: "true" @@ -64,7 +64,7 @@ jobs: name: Build and Test - root solution (larger runners) uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: - parent-job-name: "root-solution-larger-runners" + parent-job-name: "root-solution-larger-runners4" machine-types: "['buildjet-4vcpu-ubuntu-2204']" timeout-minutes: 25 set-up-sql-server: "true" From f5c3514941c1807fe2d586ca6aa5e048ca3da7bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 15:36:58 +0100 Subject: [PATCH 33/50] Trying test rename again --- .../Tests/ModuleTests/BehaviorWalkthroughsTests.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index ad161ec77..9f4e7e690 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -12,10 +12,9 @@ namespace Lombiq.OSOCE.Tests.UI.Tests.ModuleTests; -[Collection("ABehaviorWalkthroughsTests")] -public class BehaviorWalkthroughsTests : UITestBase +public class ABehaviorWalkthroughsTests : UITestBase { - public BehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) + public ABehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) : base(testOutputHelper) { } From 462325e6cc3cafbecf5b4bd5daf8e308d7afc597 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 17:13:04 +0100 Subject: [PATCH 34/50] Naming the test itself so it's at the beginning alphabetically --- .../Tests/ModuleTests/BehaviorWalkthroughsTests.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index 9f4e7e690..7463abdef 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -12,15 +12,15 @@ namespace Lombiq.OSOCE.Tests.UI.Tests.ModuleTests; -public class ABehaviorWalkthroughsTests : UITestBase +public class BehaviorWalkthroughsTests : UITestBase { - public ABehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) + public BehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) : base(testOutputHelper) { } [Fact] - public Task WalkthroughsShouldWorkCorrectly() => + public Task AllWalkthroughsShouldWorkCorrectly() => ExecuteTestAsync( context => context.RunSetupAndTestWalkthroughsBehaviorAsync(), // Could be removed if https://github.com/shepherd-pro/shepherd/issues/2555 is fixed. From 897cf74d6cd4319448b9021c95cabd1cb95a11a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 18:11:00 +0100 Subject: [PATCH 35/50] Revert "Naming the test itself so it's at the beginning alphabetically" This reverts commit 462325e6cc3cafbecf5b4bd5daf8e308d7afc597. --- .../Tests/ModuleTests/BehaviorWalkthroughsTests.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index 7463abdef..9f4e7e690 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -12,15 +12,15 @@ namespace Lombiq.OSOCE.Tests.UI.Tests.ModuleTests; -public class BehaviorWalkthroughsTests : UITestBase +public class ABehaviorWalkthroughsTests : UITestBase { - public BehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) + public ABehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) : base(testOutputHelper) { } [Fact] - public Task AllWalkthroughsShouldWorkCorrectly() => + public Task WalkthroughsShouldWorkCorrectly() => ExecuteTestAsync( context => context.RunSetupAndTestWalkthroughsBehaviorAsync(), // Could be removed if https://github.com/shepherd-pro/shepherd/issues/2555 is fixed. From 827760a285f83e35df29c4216a553a696ed718ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 18:13:30 +0100 Subject: [PATCH 36/50] Reverting workflow, increasing timeouts --- .github/workflows/build-and-test-windows.yml | 5 +- .github/workflows/build-and-test.yml | 117 ++++++++++++------- 2 files changed, 75 insertions(+), 47 deletions(-) diff --git a/.github/workflows/build-and-test-windows.yml b/.github/workflows/build-and-test-windows.yml index cb3d4b400..25449c982 100644 --- a/.github/workflows/build-and-test-windows.yml +++ b/.github/workflows/build-and-test-windows.yml @@ -36,8 +36,9 @@ jobs: uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: parent-job-name: "root-solution-larger-runners" - # Should be windows-2022-8core but temporarily isn't due to this bug: https://github.com/Lombiq/GitHub-Actions/issues/320. - # Once this is reverted, timeout-minutes below should also be reverted to 30 and dotnet-test-process-timeout to 360000. + # Should be windows-2022-8core but temporarily isn't due to this bug: + # https://github.com/Lombiq/GitHub-Actions/issues/320. Once this is reverted, timeout-minutes below should also be + # reverted to 30 and dotnet-test-process-timeout to 360000. machine-types: "['windows-2022']" timeout-minutes: 60 set-up-sql-server: "true" diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 443e88c89..90822e102 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -8,71 +8,98 @@ on: - dev jobs: - build-and-test-larger-runners1: + build-and-test-larger-runners: if: github.ref_name != github.event.repository.default_branch name: Build and Test - root solution (larger runners) uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: - parent-job-name: "root-solution-larger-runners1" + parent-job-name: "root-solution-larger-runners" machine-types: "['buildjet-4vcpu-ubuntu-2204']" - timeout-minutes: 25 + timeout-minutes: 30 set-up-sql-server: "true" set-up-azurite: "true" ui-test-parallelism: 0 build-create-binary-log: "true" - dotnet-test-process-timeout: 480000 + dotnet-test-process-timeout: 540000 build-enable-nuget-caching: "true" build-enable-npm-caching: "true" - cancel-in-progress-for-this-pr: "false" - build-and-test-larger-runners2: - if: github.ref_name != github.event.repository.default_branch - name: Build and Test - root solution (larger runners) + build-and-test-standard-runners: + # Since dev builds are not awaited by anyone, they can run on the slower free runners. + if: github.ref_name == github.event.repository.default_branch + name: Build and Test - root solution (standard runners) uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: - parent-job-name: "root-solution-larger-runners2" - machine-types: "['buildjet-4vcpu-ubuntu-2204']" - timeout-minutes: 25 + parent-job-name: "root-solution-standard-runners" + timeout-minutes: 50 set-up-sql-server: "true" set-up-azurite: "true" - ui-test-parallelism: 0 build-create-binary-log: "true" - dotnet-test-process-timeout: 480000 - build-enable-nuget-caching: "true" - build-enable-npm-caching: "true" - cancel-in-progress-for-this-pr: "false" + dotnet-test-process-timeout: 720000 - build-and-test-larger-runners3: - if: github.ref_name != github.event.repository.default_branch - name: Build and Test - root solution (larger runners) + build-and-test-nuget-test: + name: Build and Test - NuGetTest solution uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: - parent-job-name: "root-solution-larger-runners3" - machine-types: "['buildjet-4vcpu-ubuntu-2204']" - timeout-minutes: 25 - set-up-sql-server: "true" - set-up-azurite: "true" - ui-test-parallelism: 0 - build-create-binary-log: "true" - dotnet-test-process-timeout: 480000 - build-enable-nuget-caching: "true" - build-enable-npm-caching: "true" - cancel-in-progress-for-this-pr: "false" + parent-job-name: nuget-solution + build-directory: NuGetTest + timeout-minutes: 20 + dotnet-test-process-timeout: 420000 - build-and-test-larger-runners4: - if: github.ref_name != github.event.repository.default_branch - name: Build and Test - root solution (larger runners) - uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev + spelling: + name: Spelling + uses: Lombiq/GitHub-Actions/.github/workflows/spelling.yml@dev with: - parent-job-name: "root-solution-larger-runners4" - machine-types: "['buildjet-4vcpu-ubuntu-2204']" - timeout-minutes: 25 - set-up-sql-server: "true" - set-up-azurite: "true" - ui-test-parallelism: 0 - build-create-binary-log: "true" - dotnet-test-process-timeout: 480000 - build-enable-nuget-caching: "true" - build-enable-npm-caching: "true" - cancel-in-progress-for-this-pr: "false" + additional-dictionaries: | + cspell:csharp/csharp.txt + cspell:css/dict/css.txt + cspell:fullstack/dict/fullstack.txt + cspell:html-symbol-entities/entities.txt + cspell:html/dict/html.txt + cspell:html/src/svg.txt + cspell:node/dict/node.txt + cspell:npm/dict/npm.txt + lombiq-lgha:dictionaries/Liquid.txt + lombiq-lgha:dictionaries/Xml.txt + lombiq-lgha:dictionaries/Lombiq.people.txt + lombiq-lgha:dictionaries/Security.txt + + powershell-static-code-analysis: + name: PowerShell Static Code Analysis + uses: Lombiq/PowerShell-Analyzers/.github/workflows/static-code-analysis.yml@dev + with: + machine-types: '["ubuntu-22.04"]' + + yaml-linting: + name: YAML Linting + uses: Lombiq/GitHub-Actions/.github/workflows/yaml-lint.yml@issue/OSOE-188 + with: + config-file-path: tools/Lombiq.GitHub.Actions/.trunk/configs/.yamllint.yaml + search-path: . + + post-pull-request-checks-automation: + name: Post Pull Request Checks Automation + needs: [build-and-test-larger-runners, build-and-test-nuget-test, spelling, powershell-static-code-analysis] + if: github.event.pull_request != '' + uses: Lombiq/GitHub-Actions/.github/workflows/post-pull-request-checks-automation.yml@dev + secrets: + JIRA_BASE_URL: ${{ secrets.DEFAULT_JIRA_BASE_URL }} + JIRA_USER_EMAIL: ${{ secrets.DEFAULT_JIRA_USER_EMAIL }} + JIRA_API_TOKEN: ${{ secrets.DEFAULT_JIRA_API_TOKEN }} + MERGE_TOKEN: ${{ secrets.LOMBIQBOT_GITHUB_PERSONAL_ACCESS_TOKEN }} + add-windows-build-warning-label: + name: Add Windows Build Warning Label + runs-on: ubuntu-22.04 + timeout-minutes: 2 + needs: [build-and-test-larger-runners, build-and-test-nuget-test, powershell-static-code-analysis] + steps: + - name: Add Windows Build Warning Label + # v2.0.0 + uses: buildsville/add-remove-label@eeae411a9be2e173f2420e1644514edbecc4e835 + with: + # The token is necessary to be able to add the label even if the workflow is triggered by a pull request coming + # from a fork. + token: ${{ secrets.LOMBIQBOT_GITHUB_PERSONAL_ACCESS_TOKEN }} + labels: requires-windows-build + type: add From 5159e74d20d66a7585760f3d0f57b2542597c6d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 18:14:54 +0100 Subject: [PATCH 37/50] Again temporarily allowing parallel builds, and enabling Windows builds --- .github/workflows/build-and-test-windows.yml | 4 +++- .github/workflows/build-and-test.yml | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test-windows.yml b/.github/workflows/build-and-test-windows.yml index 25449c982..06031a56f 100644 --- a/.github/workflows/build-and-test-windows.yml +++ b/.github/workflows/build-and-test-windows.yml @@ -38,7 +38,7 @@ jobs: parent-job-name: "root-solution-larger-runners" # Should be windows-2022-8core but temporarily isn't due to this bug: # https://github.com/Lombiq/GitHub-Actions/issues/320. Once this is reverted, timeout-minutes below should also be - # reverted to 30 and dotnet-test-process-timeout to 360000. + # reverted to 30 and dotnet-test-process-timeout to 540000. machine-types: "['windows-2022']" timeout-minutes: 60 set-up-sql-server: "true" @@ -49,6 +49,7 @@ jobs: # Running ZAP for security scans in Docker under GHA Windows runners won't work since such virtualization is not # supported by GHA. test-filter: "FullyQualifiedName!~SecurityScanningTests" + cancel-in-progress-for-this-pr: "false" build-and-test-standard-runners: # Since dev builds are not awaited by anyone, they can run on the slower free runners. @@ -82,6 +83,7 @@ jobs: # Running ZAP for security scans in Docker under GHA Windows runners won't work since such virtualization is not # supported by GHA. test-filter: "FullyQualifiedName!~SecurityScanningTests" + cancel-in-progress-for-this-pr: "false" powershell-static-code-analysis: if: github.ref_name == github.event.repository.default_branch || diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 90822e102..7ffc828fa 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -23,6 +23,7 @@ jobs: dotnet-test-process-timeout: 540000 build-enable-nuget-caching: "true" build-enable-npm-caching: "true" + cancel-in-progress-for-this-pr: "false" build-and-test-standard-runners: # Since dev builds are not awaited by anyone, they can run on the slower free runners. @@ -45,6 +46,7 @@ jobs: build-directory: NuGetTest timeout-minutes: 20 dotnet-test-process-timeout: 420000 + cancel-in-progress-for-this-pr: "false" spelling: name: Spelling @@ -63,6 +65,7 @@ jobs: lombiq-lgha:dictionaries/Xml.txt lombiq-lgha:dictionaries/Lombiq.people.txt lombiq-lgha:dictionaries/Security.txt + cancel-in-progress-for-this-pr: "false" powershell-static-code-analysis: name: PowerShell Static Code Analysis From 650c3a0961a07f26339ff9ffda381b5f85acdfc4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 18:17:03 +0100 Subject: [PATCH 38/50] Reverting test name --- .../Tests/ModuleTests/BehaviorWalkthroughsTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs index 9f4e7e690..4ed7e1ad1 100644 --- a/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs +++ b/test/Lombiq.OSOCE.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs @@ -12,9 +12,9 @@ namespace Lombiq.OSOCE.Tests.UI.Tests.ModuleTests; -public class ABehaviorWalkthroughsTests : UITestBase +public class BehaviorWalkthroughsTests : UITestBase { - public ABehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) + public BehaviorWalkthroughsTests(ITestOutputHelper testOutputHelper) : base(testOutputHelper) { } From 42d275a4f0eecb749f2788008bfd5ea796b59f4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 18:17:20 +0100 Subject: [PATCH 39/50] Enabling Windows builds for workflows temporarily --- .github/workflows/build-and-test-windows.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/build-and-test-windows.yml b/.github/workflows/build-and-test-windows.yml index 06031a56f..30c13049d 100644 --- a/.github/workflows/build-and-test-windows.yml +++ b/.github/workflows/build-and-test-windows.yml @@ -4,9 +4,7 @@ name: Build and Test Windows # Windows builds are much slower and more expensive than Ubuntu ones, and them catching issues that aren't surfaced # under Ubuntu is rare (but does happen). So, not running them for every push of every PR. on: - workflow_dispatch: pull_request: - types: [labeled] push: branches: - dev From abd28362f52cbe82f79e815e8d61a1ef59a46da3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 18:21:16 +0100 Subject: [PATCH 40/50] Fixing Windows build --- .github/workflows/build-and-test-windows.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-and-test-windows.yml b/.github/workflows/build-and-test-windows.yml index 30c13049d..73d2265b8 100644 --- a/.github/workflows/build-and-test-windows.yml +++ b/.github/workflows/build-and-test-windows.yml @@ -28,8 +28,6 @@ jobs: type: remove build-and-test-larger-runners: - if: github.ref_name != github.event.repository.default_branch && - (github.event_name == 'workflow_dispatch' || github.event.label.name == 'run-windows-build') name: Build and Test Windows - root solution (larger runners) uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: @@ -76,8 +74,8 @@ jobs: parent-job-name: "nuget-solution" machine-types: "['windows-2022']" build-directory: NuGetTest - timeout-minutes: 25 - dotnet-test-process-timeout: 360000 + timeout-minutes: 30 + dotnet-test-process-timeout: 420000 # Running ZAP for security scans in Docker under GHA Windows runners won't work since such virtualization is not # supported by GHA. test-filter: "FullyQualifiedName!~SecurityScanningTests" From 8879ab2fd5af0a9fd450aba4e8b6170836a7c9f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 18:22:12 +0100 Subject: [PATCH 41/50] And NuGetTest Windows builds too --- .github/workflows/build-and-test-windows.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/build-and-test-windows.yml b/.github/workflows/build-and-test-windows.yml index 73d2265b8..36074319f 100644 --- a/.github/workflows/build-and-test-windows.yml +++ b/.github/workflows/build-and-test-windows.yml @@ -65,9 +65,6 @@ jobs: test-filter: "FullyQualifiedName!~SecurityScanningTests" build-and-test-nuget-test: - if: github.ref_name == github.event.repository.default_branch || - github.event_name == 'workflow_dispatch' || - github.event.label.name == 'run-windows-build' name: Build and Test Windows - NuGetTest solution uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: From 7df888ebe6aa7d5e5177130a769887b308267ee1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 18:23:07 +0100 Subject: [PATCH 42/50] Dummy change to kick off build --- .github/workflows/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 .github/workflows/New Text Document.txt diff --git a/.github/workflows/New Text Document.txt b/.github/workflows/New Text Document.txt new file mode 100644 index 000000000..e69de29bb From 1116cf636674062990908c94712f57c2ad01c875 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 18:23:28 +0100 Subject: [PATCH 43/50] Revert "Dummy change to kick off build" This reverts commit 7df888ebe6aa7d5e5177130a769887b308267ee1. --- .github/workflows/New Text Document.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .github/workflows/New Text Document.txt diff --git a/.github/workflows/New Text Document.txt b/.github/workflows/New Text Document.txt deleted file mode 100644 index e69de29bb..000000000 From d7ec70bbec0d89f49f3bcd16780f717b7636af39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 19:02:05 +0100 Subject: [PATCH 44/50] Lombiq.Walkthroughs UI test fix --- src/Modules/Lombiq.Walkthroughs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index 854f8bf71..9b567759d 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit 854f8bf711c408840ecf9448f517ab4b30f77f61 +Subproject commit 9b567759de26b3c15bed031b489c6db17315aeb7 From 39fe13057a7dce769ce36520aa20a8a16e6c697b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 19:23:37 +0100 Subject: [PATCH 45/50] Removing now unnecessary retry in Lombiq.Walkthroughs --- src/Modules/Lombiq.Walkthroughs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index 9b567759d..b7b92ec3f 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit 9b567759de26b3c15bed031b489c6db17315aeb7 +Subproject commit b7b92ec3fc7bef0ab6c209cbf99405f8f8f9ab1f From 840d6e4ddb81d5bd2333882ea61a0b271f6d6b1d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 20:28:45 +0100 Subject: [PATCH 46/50] Mergeable version of workflows --- .github/workflows/build-and-test-windows.yml | 13 +++++++++---- .github/workflows/build-and-test.yml | 3 --- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-and-test-windows.yml b/.github/workflows/build-and-test-windows.yml index 36074319f..755210cbb 100644 --- a/.github/workflows/build-and-test-windows.yml +++ b/.github/workflows/build-and-test-windows.yml @@ -4,7 +4,9 @@ name: Build and Test Windows # Windows builds are much slower and more expensive than Ubuntu ones, and them catching issues that aren't surfaced # under Ubuntu is rare (but does happen). So, not running them for every push of every PR. on: + workflow_dispatch: pull_request: + types: [labeled] push: branches: - dev @@ -28,6 +30,8 @@ jobs: type: remove build-and-test-larger-runners: + if: github.ref_name != github.event.repository.default_branch && + (github.event_name == 'workflow_dispatch' || github.event.label.name == 'run-windows-build') name: Build and Test Windows - root solution (larger runners) uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: @@ -45,7 +49,6 @@ jobs: # Running ZAP for security scans in Docker under GHA Windows runners won't work since such virtualization is not # supported by GHA. test-filter: "FullyQualifiedName!~SecurityScanningTests" - cancel-in-progress-for-this-pr: "false" build-and-test-standard-runners: # Since dev builds are not awaited by anyone, they can run on the slower free runners. @@ -65,18 +68,20 @@ jobs: test-filter: "FullyQualifiedName!~SecurityScanningTests" build-and-test-nuget-test: + if: github.ref_name == github.event.repository.default_branch || + github.event_name == 'workflow_dispatch' || + github.event.label.name == 'run-windows-build' name: Build and Test Windows - NuGetTest solution uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev with: parent-job-name: "nuget-solution" machine-types: "['windows-2022']" build-directory: NuGetTest - timeout-minutes: 30 - dotnet-test-process-timeout: 420000 + timeout-minutes: 25 + dotnet-test-process-timeout: 360000 # Running ZAP for security scans in Docker under GHA Windows runners won't work since such virtualization is not # supported by GHA. test-filter: "FullyQualifiedName!~SecurityScanningTests" - cancel-in-progress-for-this-pr: "false" powershell-static-code-analysis: if: github.ref_name == github.event.repository.default_branch || diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 7ffc828fa..90822e102 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -23,7 +23,6 @@ jobs: dotnet-test-process-timeout: 540000 build-enable-nuget-caching: "true" build-enable-npm-caching: "true" - cancel-in-progress-for-this-pr: "false" build-and-test-standard-runners: # Since dev builds are not awaited by anyone, they can run on the slower free runners. @@ -46,7 +45,6 @@ jobs: build-directory: NuGetTest timeout-minutes: 20 dotnet-test-process-timeout: 420000 - cancel-in-progress-for-this-pr: "false" spelling: name: Spelling @@ -65,7 +63,6 @@ jobs: lombiq-lgha:dictionaries/Xml.txt lombiq-lgha:dictionaries/Lombiq.people.txt lombiq-lgha:dictionaries/Security.txt - cancel-in-progress-for-this-pr: "false" powershell-static-code-analysis: name: PowerShell Static Code Analysis From a300fa44e9bcaf539d0d37a98d07fdb1cb1953c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 21:40:18 +0100 Subject: [PATCH 47/50] Lombiq.Walkthroughs NuGet alpha release --- .../src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj | 2 +- .../Lombiq.OSOCE.NuGet.Tests.UI.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NuGetTest/src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj b/NuGetTest/src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj index f7582ea77..977c1f393 100644 --- a/NuGetTest/src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj +++ b/NuGetTest/src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj @@ -53,7 +53,7 @@ - + diff --git a/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Lombiq.OSOCE.NuGet.Tests.UI.csproj b/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Lombiq.OSOCE.NuGet.Tests.UI.csproj index 257ea3ea6..16eaf40de 100644 --- a/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Lombiq.OSOCE.NuGet.Tests.UI.csproj +++ b/NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Lombiq.OSOCE.NuGet.Tests.UI.csproj @@ -44,7 +44,7 @@ - + runtime; build; native; contentfiles; analyzers; buildtransitive From fc07840819fb978501122090ed7392af656b1135 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 23:08:11 +0100 Subject: [PATCH 48/50] Increasing Windows NuGetTest timeout too --- .github/workflows/build-and-test-windows.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-and-test-windows.yml b/.github/workflows/build-and-test-windows.yml index 755210cbb..dc04e1384 100644 --- a/.github/workflows/build-and-test-windows.yml +++ b/.github/workflows/build-and-test-windows.yml @@ -77,8 +77,8 @@ jobs: parent-job-name: "nuget-solution" machine-types: "['windows-2022']" build-directory: NuGetTest - timeout-minutes: 25 - dotnet-test-process-timeout: 360000 + timeout-minutes: 30 + dotnet-test-process-timeout: 420000 # Running ZAP for security scans in Docker under GHA Windows runners won't work since such virtualization is not # supported by GHA. test-filter: "FullyQualifiedName!~SecurityScanningTests" From b9d509cb805874ef8017631a388a61ac110d9a2a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 12 Feb 2024 23:45:56 +0100 Subject: [PATCH 49/50] Lombiq.UITestingToolbox monkey testing sample speed-up --- test/Lombiq.UITestingToolbox | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Lombiq.UITestingToolbox b/test/Lombiq.UITestingToolbox index d23282e43..4c9600385 160000 --- a/test/Lombiq.UITestingToolbox +++ b/test/Lombiq.UITestingToolbox @@ -1 +1 @@ -Subproject commit d23282e4344e0de4b8b959c3d39000ead23d815f +Subproject commit 4c960038594305775977b7e14433fedc4c63480f From aa65673bab64ca180133467512d4325f0203a3d6 Mon Sep 17 00:00:00 2001 From: Szabolcs Deme Date: Tue, 13 Feb 2024 17:38:12 +0100 Subject: [PATCH 50/50] Updating Lombiq.UITestingToolbox and Lombiq.Walkthroughs to latest dev --- src/Modules/Lombiq.Walkthroughs | 2 +- test/Lombiq.UITestingToolbox | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs index b7b92ec3f..352cc4251 160000 --- a/src/Modules/Lombiq.Walkthroughs +++ b/src/Modules/Lombiq.Walkthroughs @@ -1 +1 @@ -Subproject commit b7b92ec3fc7bef0ab6c209cbf99405f8f8f9ab1f +Subproject commit 352cc4251310d7e1f4fd7633f1e11115905e785a diff --git a/test/Lombiq.UITestingToolbox b/test/Lombiq.UITestingToolbox index 4c9600385..5b283da68 160000 --- a/test/Lombiq.UITestingToolbox +++ b/test/Lombiq.UITestingToolbox @@ -1 +1 @@ -Subproject commit 4c960038594305775977b7e14433fedc4c63480f +Subproject commit 5b283da681a5a72c223ee59a72ce99c32521de29