From f2e2616dbb4e8d5f7be1cd1fa1d68c0ca7aa559c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 1 Nov 2024 23:20:41 +0100 Subject: [PATCH 1/6] Missing job name --- .github/workflows/publish-nuget.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/publish-nuget.yml b/.github/workflows/publish-nuget.yml index 4b26cfc..fac826d 100644 --- a/.github/workflows/publish-nuget.yml +++ b/.github/workflows/publish-nuget.yml @@ -7,6 +7,7 @@ on: jobs: publish-nuget: + name: Publish to NuGet uses: Lombiq/GitHub-Actions/.github/workflows/publish-nuget.yml@dev secrets: API_KEY: ${{ secrets.DEFAULT_NUGET_PUBLISH_API_KEY }} From 5b4c1bfd143dd575fa7a9f6061b85d7aa9f34e9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 1 Nov 2024 23:22:33 +0100 Subject: [PATCH 2/6] Adding validate-nuget-publish --- .github/workflows/validate-nuget-publish.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/workflows/validate-nuget-publish.yml diff --git a/.github/workflows/validate-nuget-publish.yml b/.github/workflows/validate-nuget-publish.yml new file mode 100644 index 0000000..b9d47ec --- /dev/null +++ b/.github/workflows/validate-nuget-publish.yml @@ -0,0 +1,12 @@ +name: Validate NuGet Publish + +on: + pull_request: + push: + branches: + - dev + +jobs: + validate-nuget-publish: + name: Validate NuGet Publish + uses: Lombiq/GitHub-Actions/.github/workflows/validate-nuget-publish.yml@issue/OSOE-864 From 142671305d7dca67b5292425e49cb9f537b4ec2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 1 Nov 2024 23:22:42 +0100 Subject: [PATCH 3/6] Pointing GHA to issue branch --- .github/workflows/publish-nuget.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-nuget.yml b/.github/workflows/publish-nuget.yml index fac826d..76c939b 100644 --- a/.github/workflows/publish-nuget.yml +++ b/.github/workflows/publish-nuget.yml @@ -8,6 +8,6 @@ on: jobs: publish-nuget: name: Publish to NuGet - uses: Lombiq/GitHub-Actions/.github/workflows/publish-nuget.yml@dev + uses: Lombiq/GitHub-Actions/.github/workflows/publish-nuget.yml@issue/OSOE-864 secrets: API_KEY: ${{ secrets.DEFAULT_NUGET_PUBLISH_API_KEY }} From 9c8786b47a2c77c4f8758b829aedd19ea18335b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 1 Nov 2024 23:32:58 +0100 Subject: [PATCH 4/6] Adding test breaking change --- Services/AuditTrailContentVersionNumberService.cs | 2 +- Services/IAuditTrailContentVersionNumberService.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Services/AuditTrailContentVersionNumberService.cs b/Services/AuditTrailContentVersionNumberService.cs index d38662e..c27e055 100644 --- a/Services/AuditTrailContentVersionNumberService.cs +++ b/Services/AuditTrailContentVersionNumberService.cs @@ -13,7 +13,7 @@ public class AuditTrailContentVersionNumberService : IAuditTrailContentVersionNu public AuditTrailContentVersionNumberService(ISession session) => _session = session; - public Task GetLatestVersionNumberAsync(string contentItemId) => + public Task GetLatestVersionNumberChangedAsync(string contentItemId) => _session .Query(index => index.CorrelationId == contentItemId && index.Name == Saved) diff --git a/Services/IAuditTrailContentVersionNumberService.cs b/Services/IAuditTrailContentVersionNumberService.cs index 0c48bce..e591689 100644 --- a/Services/IAuditTrailContentVersionNumberService.cs +++ b/Services/IAuditTrailContentVersionNumberService.cs @@ -14,7 +14,7 @@ public interface IAuditTrailContentVersionNumberService /// /// Returns the current largest version number for the content item. /// - Task GetLatestVersionNumberAsync(string contentItemId); + Task GetLatestVersionNumberChangedAsync(string contentItemId); /// /// Returns the version number and its content of a specific version as of the event identified by the given @@ -30,5 +30,5 @@ public static class ContentVersionNumberServiceExtensions public static Task GetLatestVersionNumberAsync( this IAuditTrailContentVersionNumberService service, IContent content) => - service.GetLatestVersionNumberAsync(content?.ContentItem?.ContentItemId); + service.GetLatestVersionNumberChangedAsync(content?.ContentItem?.ContentItemId); } From 29acde326587351f7ef16b2c913a6bc5c39787f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 1 Nov 2024 23:51:20 +0100 Subject: [PATCH 5/6] Revert "Adding test breaking change" This reverts commit 9c8786b47a2c77c4f8758b829aedd19ea18335b1. --- Services/AuditTrailContentVersionNumberService.cs | 2 +- Services/IAuditTrailContentVersionNumberService.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Services/AuditTrailContentVersionNumberService.cs b/Services/AuditTrailContentVersionNumberService.cs index c27e055..d38662e 100644 --- a/Services/AuditTrailContentVersionNumberService.cs +++ b/Services/AuditTrailContentVersionNumberService.cs @@ -13,7 +13,7 @@ public class AuditTrailContentVersionNumberService : IAuditTrailContentVersionNu public AuditTrailContentVersionNumberService(ISession session) => _session = session; - public Task GetLatestVersionNumberChangedAsync(string contentItemId) => + public Task GetLatestVersionNumberAsync(string contentItemId) => _session .Query(index => index.CorrelationId == contentItemId && index.Name == Saved) diff --git a/Services/IAuditTrailContentVersionNumberService.cs b/Services/IAuditTrailContentVersionNumberService.cs index e591689..0c48bce 100644 --- a/Services/IAuditTrailContentVersionNumberService.cs +++ b/Services/IAuditTrailContentVersionNumberService.cs @@ -14,7 +14,7 @@ public interface IAuditTrailContentVersionNumberService /// /// Returns the current largest version number for the content item. /// - Task GetLatestVersionNumberChangedAsync(string contentItemId); + Task GetLatestVersionNumberAsync(string contentItemId); /// /// Returns the version number and its content of a specific version as of the event identified by the given @@ -30,5 +30,5 @@ public static class ContentVersionNumberServiceExtensions public static Task GetLatestVersionNumberAsync( this IAuditTrailContentVersionNumberService service, IContent content) => - service.GetLatestVersionNumberChangedAsync(content?.ContentItem?.ContentItemId); + service.GetLatestVersionNumberAsync(content?.ContentItem?.ContentItemId); } From 34ab925dd1d5a795b248f3ab6c5b12390da3201d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A1ra=20El-Saig?= Date: Mon, 4 Nov 2024 16:19:08 +0100 Subject: [PATCH 6/6] revert branch selector --- .github/workflows/publish-nuget.yml | 2 +- .github/workflows/validate-nuget-publish.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-nuget.yml b/.github/workflows/publish-nuget.yml index 76c939b..fac826d 100644 --- a/.github/workflows/publish-nuget.yml +++ b/.github/workflows/publish-nuget.yml @@ -8,6 +8,6 @@ on: jobs: publish-nuget: name: Publish to NuGet - uses: Lombiq/GitHub-Actions/.github/workflows/publish-nuget.yml@issue/OSOE-864 + uses: Lombiq/GitHub-Actions/.github/workflows/publish-nuget.yml@dev secrets: API_KEY: ${{ secrets.DEFAULT_NUGET_PUBLISH_API_KEY }} diff --git a/.github/workflows/validate-nuget-publish.yml b/.github/workflows/validate-nuget-publish.yml index b9d47ec..e2fad46 100644 --- a/.github/workflows/validate-nuget-publish.yml +++ b/.github/workflows/validate-nuget-publish.yml @@ -9,4 +9,4 @@ on: jobs: validate-nuget-publish: name: Validate NuGet Publish - uses: Lombiq/GitHub-Actions/.github/workflows/validate-nuget-publish.yml@issue/OSOE-864 + uses: Lombiq/GitHub-Actions/.github/workflows/validate-nuget-publish.yml@dev