Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence parsing broken #6

Open
VarIr opened this issue Nov 9, 2020 · 0 comments
Open

Sequence parsing broken #6

VarIr opened this issue Nov 9, 2020 · 0 comments

Comments

@VarIr
Copy link
Contributor

VarIr commented Nov 9, 2020

We parse sequences with Biopython.SeqIO, using specific Alphabets. In Bio==1.78 these were removed altogether, which breaks phenotrex.
For now, we can simply require Bio<=1.77.

We could simply move the logic from old Biopython code to phenotrex. It's a matter of a few lines of code. (And improve that awful code, while at it. Just have a look at how _verify_alphabet works...)

On the other hand, the current parsing situation is not optimal, since a protein sequence made only from letters from the ambigous DNA alphabet would be recognized as DNA, with no possibility for the user to override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant