Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back stripes #8

Closed
koppor opened this issue Aug 4, 2024 · 3 comments · Fixed by JabRef/jabref#11579
Closed

Bring back stripes #8

koppor opened this issue Aug 4, 2024 · 3 comments · Fixed by JabRef/jabref#11579

Comments

@koppor
Copy link

koppor commented Aug 4, 2024

Old JabRef:

image

New JabRef (introduced by JabRef#11510)

image

See that other apps also have these stripes: https://www.papersapp.com/

If they have too high contrast, try to play around with only a slight luminance difference.

Not everything got worse with JabRef 4.0 😅.

Screenshot JabRef 3.8.1: https://www.filehorse.com/download-jabref/28848/

(The spacing bertween the lines can also be reduced.)

@subhramit
Copy link

subhramit commented Aug 5, 2024

+1 on this. The stripes looked better.

@LoayGhreeb
Copy link
Owner

JabRef#11510 (comment).

It might be worthwhile enhancing the colours of state 2 (contains search term but does not belong to group) and state 3 (does not contain search term but belongs to group), i. e. making them darker. At the moment, especially the greyish colour of state 2 is very similar to the grey in state 1 (state 1, which are items that contain both the search term and belong to the selected group, will display lines alternating white and grey colours when multiple elements are present).

If I revert the changes and apply stripes only to the first state, there will be three colors but only two states (matched to groups and not matched to groups):

  • Matched to groups will have two colors.
  • Not matched to groups will have one color.

image

Applying stripes to all states would be very distracting as each of the four states would have two colors:
image

@LoayGhreeb
Copy link
Owner

LoayGhreeb commented Aug 5, 2024

Can you check if this is better?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants