Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Highlighted text does not communicate with google translate extension #103

Open
7 tasks done
cjs937 opened this issue Oct 11, 2022 · 2 comments
Open
7 tasks done
Labels
bug Something isn't working

Comments

@cjs937
Copy link

cjs937 commented Oct 11, 2022

Checklist

  • This is an issue for Hyperchat, not LiveTL. I will go to the LiveTL repo to report an issue with LiveTL.
  • This issue is not a matter of opinion. If it is, I will use the feature suggestion issue template.
  • I have checked for a duplicate or similar issue. I made sure to check closed issues as well.
  • I am still able to reproduce the issue after I reinstall the extension.
  • I have clear instructions to reproduce the bug, even on another machine.
  • I am not suggesting a feature. If I am, I will use the feature suggestion issue template.
  • By submitting this issue, you agree to follow our Code of Conduct

Describe the bug

When Hyperchat is disabled, you can highlight a message in chat & click on the google translate extension, and the highlighted text will automatically copy over and get translated. When Hyperchat is on however this doesn't work and you have to copy, paste, and translate manually.

Steps To Reproduce

  1. Download the google translate extension and pin it to your extension bar
  2. Open a stream or VOD and highlight a message in chat
  3. Click on the translate extension icon in your bar

Expected behavior

If Hyperchat is disabled the highlighted text should copy over and translate automatically. I would expect the same to happen when Hyperchat is enabled as well.

What browsers are you seeing the problem on?

Chrome

Anything else?

No response

@cjs937 cjs937 added the bug Something isn't working label Oct 11, 2022
@KentoNishi
Copy link
Member

Chrome prevents extensions from cross-interacting unless the developers of both extensions explicitly implement support. There is a theoretical workaround but it'll take a lot of internal reworking, so unfortunately you're going to have to use the translate feature built into hyperchat... Sorry!

@cjs937
Copy link
Author

cjs937 commented Oct 11, 2022

That's unfortunate. Thanks for the heads up though!
This is getting into feature request territory, but it would be nice to have a way to do something like this embedded into Hyperchat instead. Trying to learn Japanese and it's nice to leave the chat in its default state and only translate specific kanji or words when necessary. Maybe adding an option to translate text on click could solve this as well (like what the translate feature already does, just in reverse).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants