Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4475 [Nice to have] Update layout for manage custom tasks #3547

Open
wants to merge 5 commits into
base: integration
Choose a base branch
from

Conversation

kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented Nov 23, 2024

Description

This adds the "CantFindCustomTask" block we use in Expense + Revenue Type Selection into Tasks. It was a lower priority nice-to-have, but with the discussion around adding animals to custom tasks, it might be especially nice. There is no code complexity to the change so I have opened it.

Done in this PR:

  • Simple conversion to TS of <CantFindCustomTask /> because even I was confused by the meaning of the props I had set up on this component ("miscellaneousConfig"??)
  • Simple Storybook story since previously it had only been integrated within the PureFinanceTypeSelection story. This is also to make the props a bit clearer
  • breakpoint adjust to fix this small layout bug which I think had just gone under our radar since the menu release:
Screenshot 2024-11-22 at 3 49 01 PM

Not done:

  • Did not migrate <CantFindCustomType /> out of Finances, despite its new use in tasks
  • Did not make the miscellaneous functionality more general (i.e. the string is hard-coded for Expense types right now, which is still fine because it's the only place that uses that functionality)
  • This was to avoid making any changes that would involve touching finances code & thereby to keep scope slim

Jira link: https://lite-farm.atlassian.net/browse/LF-4475

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak

I SKIPPED ADDING MISSING! It seems the consensus is that we can do this now 😁

@kathyavini kathyavini added the enhancement New feature or request label Nov 23, 2024
@kathyavini kathyavini self-assigned this Nov 23, 2024
@kathyavini kathyavini requested review from a team as code owners November 23, 2024 00:27
@kathyavini kathyavini requested review from antsgar and Duncan-Brain and removed request for a team November 23, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant