Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Guest Access #56

Closed
MuadDibVV opened this issue Jun 23, 2021 · 6 comments
Closed

[FEATURE_REQUEST] Guest Access #56

MuadDibVV opened this issue Jun 23, 2021 · 6 comments
Assignees
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@MuadDibVV
Copy link

Is it possible to have a guest access without any credential and an admin access with a button for an admin use ?

@MuadDibVV MuadDibVV added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Jun 23, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Jun 23, 2021

Hmm, yes it could be possible. So that no login is required for view-only access, but the user must be authenticated as an admin in order for config changes to be written to the disk from the UI?

@MuadDibVV
Copy link
Author

yes
I thought that allowConfigEdit: false would meet my need (configuration only by yaml (I use the docker version)) but because I don't use users it doesn't seem to work

@Lissy93
Copy link
Owner

Lissy93 commented Jun 23, 2021

Oh that (allowConfigEdit: false) actually should work. A user can still apply changes locally, but those changes will only ever be saved in their browsers local storage. So if allowConfigEdit: false is set, then no user can write changes to the conf.yml file through the UI.

@MuadDibVV
Copy link
Author

Ok thanks, so I confirm that a guest access could be interesting

@Lissy93
Copy link
Owner

Lissy93 commented Aug 18, 2021

Sorry that this took me so long to get round to. I initially thought that users who'd want more advanced login controls would be hosting their own authentication server, but I think I was wrong.

So I've implemented this in PR #167 which I will merge now, and will be released in V 1.6.2. You will then be able to use it by setting appConfig.enableGuestAccess: true

Example

appConfig:
  enableGuestAccess: true # Now login isn't required to access dashboard
  auth: # You still need to have users though
    - user: alicia
      hash: 4D1E58C90B3B94BCAD9848ECCACD6D2A8C9FBC5CA913304BBA5CDEAB36FEEFA3
      type: admin
    - user: bob
      hash: 5E884898DA28047151D0E56F8DC6292773603D0D6AABBDD62A11EF721D1542D8

Then, even when not logged in you will be able to view your dashboard. Guests cannot write any changes to disk, but can modify settings locally (saved just in their browser). Click the login button in the top-right to sign in as your normal user in order to make changes to your config file.

@Lissy93
Copy link
Owner

Lissy93 commented Aug 19, 2021

@MuadDibVV - Is this still something you want included? I am unsure weather to keep it in the app, as it adds a lot of logic + code for a small feature? Do let me know so I don't revert something you plan to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Development

No branches or pull requests

2 participants