Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No longer builds on startup #1051

Closed
5 tasks done
rtm516 opened this issue Jan 9, 2023 · 15 comments
Closed
5 tasks done

[BUG] No longer builds on startup #1051

rtm516 opened this issue Jan 9, 2023 · 15 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.1.2

Comments

@rtm516
Copy link
Contributor

rtm516 commented Jan 9, 2023

Environment

Self-Hosted (Docker)

System

Chrome 108 on Windows 10 - Docker 20.10.17 on Raspbian 11 bullseye

Version

2.1.1

Describe the problem

For a few versions now Dashy starts up and doesn't have my custom styles applied so I need to connect and run yarn build manually.
I have a file mounted at /app/src/styles/user-defined-themes.scss to apply my custom scss which used to work fine after updates, but now I need to trigger a manual build every container update.
My containers are automatically update using watchtowerr

Additional info

The below is the output of the container on start

yarn run v1.22.15
$ node server
Checking config file against schema...
✔️ Config file is valid, no issues found
 ██████╗  █████╗ ███████╗██╗  ██╗██╗   ██╗
 ██╔══██╗██╔══██╗██╔════╝██║  ██║╚██╗ ██╔╝
 ██║  ██║███████║███████╗███████║ ╚████╔╝
 ██║  ██║██╔══██║╚════██║██╔══██║  ╚██╔╝
 ██████╔╝██║  ██║███████║██║  ██║   ██║
 ╚═════╝ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═╝   ╚═╝
*******************************************************************************************
Welcome to Dashy! 🚀
Your new dashboard is now up and running with Docker
*******************************************************************************************
🔐 HTTPS server successfully started (port: 443 of container)
Using Dashy V-2.1.1. Update Check Complete
✅ Dashy is Up-to-Date

Please tick the boxes

@rtm516 rtm516 added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Jan 9, 2023
@vovinski
Copy link

vovinski commented Jan 17, 2023

I confirm this problem. You have to manually enter the container and run the yarn build command. Only then does Dashy rebuild and themes and configurations are applied. Multipages also don't work until you manually rebuild Dashy.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Jan 17, 2023
@silicon2022
Copy link

silicon2022 commented Jan 18, 2023

You may solve this by adding entrypoint: ["yarn","build-and-start"] to your docker-compose.yml. The drawback is whenever you click the "save on disk" button, it will build the whole project again. It can be CPU-consuming for some low-end VM. Hope there will be a more elegant way to solve this problem.

here is my docker-compose.yml
version: "3.8"

services:
dashy:
container_name: Dashy
hostname: dashy
# Pull latest image from DockerHub
image: lissy93/dashy:latest

# Pass in your config file below, by specifying the path on your host machine
volumes:
  - /home/ubuntu/dashy/public:/app/public
  - type: bind
    source: /home/ubuntu/dashy/.env
    target: /app/public/.env
entrypoint: ["yarn","build-and-start"]

# Set port that web service will be served on. Keep container port as 80
ports:
  - 4000:80

# Set any environmental variables
environment:
  - NODE_ENV=production

# Specify restart policy
restart: unless-stopped

# Configure healthchecks
healthcheck:
  test: ['CMD', 'node', '/app/services/healthcheck']
  interval: 1m30s
  timeout: 10s
  retries: 3
  start_period: 40s

If I have time this weekend, I will write articles on how to build Dashy using docker & how to use Nginx Proxy Manager + Authelia for authentication.

Btw the solution to this issue was mentioned by coalwater. You may read the closed issue here.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Jan 18, 2023
@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Feb 19, 2023
@rtm516
Copy link
Contributor Author

rtm516 commented Feb 22, 2023

This is still relevant and happens without changing entrypoint to yarn build-and-start

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels Feb 22, 2023
@vovinski
Copy link

vovinski commented Mar 3, 2023

We will not wait for the developer's response, it seems. Is she too busy with other projects?

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 4, 2023
@iveney
Copy link

iveney commented Mar 7, 2023

I confirm this problem. You have to manually enter the container and run the yarn build command. Only then does Dashy rebuild and themes and configurations are applied. Multipages also don't work until you manually rebuild Dashy.

Can confirm this still happens to me, after I added multiple pages.

Used the UI to make edits, save, refresh, and the edit is gone. Can confirm the config file is saved locally. I have to manually trigger the rebuild from the UI.

It still builds if I restart my docker, but having to restart or trigger manually each time I make edits via UI is annoying.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Mar 7, 2023
@liss-bot
Copy link
Collaborator

liss-bot commented Apr 7, 2023

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Apr 7, 2023
@rtm516
Copy link
Contributor Author

rtm516 commented Apr 10, 2023

This is still relevant

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels Apr 10, 2023
@itsmejoeeey
Copy link
Contributor

I can confirm this is still relevant too.

Interestingly, this is a regression from 2.1.0.

Took a lot of head-scratching to understand why my Keycloak authentication configuration was not applying properly. It was caused because no build happens when the official Docker image is started.

In my opinion this issue becomes far more severe if my dashboard can become public-access if my Docker container gets recreated (without manually intervening and starting a build).

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 21, 2023
@itsmejoeeey
Copy link
Contributor

Further investigations:

I've narrowed down that this regressed in commit " 60d0b03: removed build watch and tini from container run-time".
It was pushed directly to master, so there is no linked PR or issue with more information about this change.

This change isn't in the 2.1.1 tag, so this shouldn't be an issue in the 2.1.1 docker image.
BUT.
I've noticed that the 2.1.1 Docker image was last updated 13 days ago and when viewing the Image Layer Details it seems to be executing commands as if using the master Dockerfile.

@Lissy93 Are you aware of an issue with the automated deployments deploying some form of master to the 2.1.1 tag on Docker Hub?

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 21, 2023
@liss-bot
Copy link
Collaborator

This issue has gone 3 months without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Jul 21, 2023
@itsmejoeeey
Copy link
Contributor

Still relevant. Waiting to hear back from @Lissy93.

@liss-bot liss-bot removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Jul 22, 2023
@liss-bot
Copy link
Collaborator

This issue has gone 3 months without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Oct 27, 2023
@github-project-automation github-project-automation bot moved this to Todo in Dashy V3 Oct 27, 2023
@itsmejoeeey
Copy link
Contributor

Still relevant. Waiting to hear back from @Lissy93.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels Oct 27, 2023
@Lissy93 Lissy93 closed this as completed in e626c6b Mar 3, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Triage to Done in Dashy V3 Mar 3, 2024
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 3, 2024
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.1.2
Projects
Status: Done
Development

No branches or pull requests

7 participants