Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Duplication in chain registration commands #9077

Closed
sitetester opened this issue Oct 10, 2023 · 2 comments
Closed

Duplication in chain registration commands #9077

sitetester opened this issue Oct 10, 2023 · 2 comments

Comments

@sitetester
Copy link
Contributor

Description

#9043
In this PR, duplication of registration commands was addressed by moving common code to parent class, but since it involved an out of scope change of relevant task, we can address it here.

What to do ?
Take relevant duplication of code (AND test cases) from above PR & either address it in the same PR (by re-opening it) or create another one.

Motivation

  • There were duplication for whole blocks like verifyValidators
  • Same set of tests were written for sidechain & mainchain
  • Take a look at base class methods how duplication for other parts is handled

Additional Information

  • framework/src/modules/interoperability/base_interoperability_register_chain_command.ts
  • framework/src/modules/interoperability/mainchain/commands/register_sidechain.ts
  • framework/src/modules/interoperability/sidechain/commands/register_mainchain.ts
@ishantiw ishantiw changed the title Massive duplication in chain registration commands Duplication in chain registration commands Oct 10, 2023
@sitetester
Copy link
Contributor Author

@gkoumout FYI

@shuse2
Copy link
Collaborator

shuse2 commented Dec 20, 2023

Closing this issue for no activity

@shuse2 shuse2 closed this as completed Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants