You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
The NFT module defines the createNFTEntry function which is responsible for creating a new NFT and ensuring that the NFT’s attributesArray array does not have duplicate modules
The createNFTEntry function is never called. Instead, the nftStore.save method is called directly in many locations. In some locations, such as in the create method, the attributeArray uniqueness check is copy-pasted, while in others this uniqueness property is not enforced.
In particular, two places may result in the NFT having duplicate module attributes
When a foreign NFT is received (lisk-sdk/framework/src/modules/nft/cc_commands/cc_transfer.ts#L142-L145)
When a foreign NFT is bounced (lisk-sdk/framework/src/modules/nft/cc_commands/cc_transfer.ts#L149-L152)
Other instances
lisk-sdk/framework/src/modules/nft/cc_commands/cc_transfer.ts#L116
lisk-sdk/framework/src/modules/nft/method.ts#L977
Similarly createUserEntry function is not used here and here
Similarly createEscrowEntry function is not used here
Acceptance Criteria
All places, including the ones mentioned above where internal functions can be used to save data to stores must be checked and updated
Unit tests must be added to check there are no duplicate module attributes
Additional Information
release/6.1.0
The text was updated successfully, but these errors were encountered:
Description
When a foreign NFT is received (lisk-sdk/framework/src/modules/nft/cc_commands/cc_transfer.ts#L142-L145)
When a foreign NFT is bounced (lisk-sdk/framework/src/modules/nft/cc_commands/cc_transfer.ts#L149-L152)
lisk-sdk/framework/src/modules/nft/cc_commands/cc_transfer.ts#L116
lisk-sdk/framework/src/modules/nft/method.ts#L977
Acceptance Criteria
Additional Information
release/6.1.0
The text was updated successfully, but these errors were encountered: