Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove unnecessary calls to validator.validate in commands of NFT module #8987

Closed
Tracked by #7245
Incede opened this issue Sep 14, 2023 · 0 comments
Closed
Tracked by #7245
Assignees
Milestone

Comments

@Incede
Copy link
Contributor

Incede commented Sep 14, 2023

Description

In the NFT module’s Transfer, TransferCrossChainCommand and CrossChainTransferCommand commands, the code calls validator.validate to validate the commands parameters. Calling validator.validate on a command's verify function is unnecessary because this check is already done in the state machine logic.

Acceptance Criteria

  • Remove all unnecessary calls as specified
  • Update relevant unit tests

Additional Information

release/6.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants