This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 64
Extend APIError to have errors from core #919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
changed the base branch from
release/2.0.0
to
912-fix_external_lib_def
November 28, 2018 14:50
SargeKhan
reviewed
Nov 28, 2018
shuse2
changed the base branch from
912-fix_external_lib_def
to
release/2.0.0
November 30, 2018 11:07
mitsuaki-u
reviewed
Nov 30, 2018
mitsuaki-u
previously approved these changes
Dec 3, 2018
SargeKhan
reviewed
Dec 3, 2018
SargeKhan
reviewed
Dec 3, 2018
}); | ||
}); | ||
|
||
it('should reject with "An unknown error has occured." message if there is no data is supplied', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test case any useful? Because in the following test, the request is rejected with a defined data property, and the expectation for err.message
is the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's useful, because data exists but no message, and no data is treated in the different way in the code
SargeKhan
approved these changes
Dec 3, 2018
mitsuaki-u
approved these changes
Dec 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
APIError did not have enough information to show proper error on the user side.
How did I fix it?
Add
errors
from APIResponse if exists in the error.How to test it?
Review checklist
Merge After Fix not to expose custom external library definition - Closes #912 #914