This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Fix browserify build option and remove brower field #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuaki-u
previously approved these changes
Nov 15, 2018
yatki
force-pushed
the
hotfix/851-browser_build_fail
branch
from
f6da59c to
df824ca
Compare
yatki
previously approved these changes
Nov 15, 2018
mitsuaki-u
approved these changes
Nov 16, 2018
ishantiw
approved these changes
Nov 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Browser build was not functional outside of node environment.
How did I fix it?
Remove browser key from the
package.jsonand remove--nodeflag when building for browser.How to test it?
use
dist-browser/index.jsanddist-browser/index.min.jsfrom the browser.Review checklist