This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Update address validation - Closes #832 #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuaki-u
force-pushed
the
832-Update_address_validation
branch
from
13247a9 to
8deff7b
Compare
ishantiw
reviewed
Nov 12, 2018
ishantiw
reviewed
Nov 12, 2018
ishantiw
reviewed
Nov 12, 2018
shuse2
previously requested changes
Nov 12, 2018
mitsuaki-u
force-pushed
the
832-Update_address_validation
branch
from
ae29851 to
ca16f90
Compare
shuse2
approved these changes
Nov 13, 2018
ishantiw
approved these changes
Nov 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Address validation allowed leading zeros and inclusion of
.character.How did I fix it?
Updated
validateAddressin utils.How to test it?
npm run test
Review checklist