This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Fix circular dependency in lisk-cryptography - Closes 775 #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willclarktech
suggested changes
Sep 7, 2018
shuse2
changed the title
shuse2
previously approved these changes
Sep 7, 2018
willclarktech
approved these changes
Sep 7, 2018
willclarktech
deleted the
775-remove-circular-dependency-in-cryptography
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Circular dependency in lisk-cryptography, specifically the "hexToBuffer" function in convert module being used in hash module.
How did I fix it?
Separated buffer specific logic into a new buffer module along with the corresponding tests.
How to test it?
Install, build, lint, test etc.
Review checklist