This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Disable user-agent header when client options were not provided - Closes #696 #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatki
changed the title
|
@yatki This is failing on CI. |
willclarktech
force-pushed
the
696-disable-user-agent-in-browser
branch
from
ebe627b to
b558322
Compare
willclarktech
suggested changes
Jul 16, 2018
| { | ||
| 'User-Agent': getUserAgent(options.client), | ||
| }, | ||
| getUserAgent(options.client), |
There was a problem hiding this comment.
This Object.assign call combines various headers objects. User agent is on the wrong semantic level for this. The function as written doesn't just get the user agent, it gets a headers object which happens to only include the user agent (currently). We should either use the previous pattern or rename the function something like getClientHeaders.
|
|
||
| it('should not set User-Agent header when client options were not given', () => { | ||
| apiClient = new APIClient(defaultNodes, { | ||
| version: customHeaders.version, |
There was a problem hiding this comment.
Actually version/customHeaders.version doesn't make sense here. Could you remove it from the other test too?
willclarktech
approved these changes
Jul 17, 2018
shuse2
approved these changes
Jul 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
lisk-elements is throwing Refused to set unsafe header “User-Agent”warning when it's used in browsers.
How did I fix it?
I updated getUserAgent function to return empty object when clientOptions were not provided.
How to test it?
should not set User-Agent header when client options were not given
Review checklist
commit guidelines