This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Add scenarios in integration tests relevant to lisk-p2p #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
Feb 22, 2019
| @@ -46,9 +47,9 @@ describe('Integration tests for P2P library', () => { | |||
| afterEach(async () => { | |||
| await Promise.all( | |||
| p2pNodeList.map(async p2p => { | |||
| try { | |||
| if (p2p.isActive) { | |||
There was a problem hiding this comment.
maybe filter first?
p2pNodeList.filter(p2p => p2p.isActive).map(xxx
| @@ -198,15 +211,177 @@ describe('Integration tests for P2P library', () => { | |||
| await wait(DISCOVERY_INTERVAL * 5); | |||
|
|
|||
| p2pNodeList.forEach(p2p => { | |||
| let {connectedPeers} = p2p.getNetworkStatus(); | |||
| let { connectedPeers } = p2p.getNetworkStatus(); | |||
|
I will add test cases related to the custom selection function. Issue created #1131 |
shuse2
approved these changes
Feb 22, 2019
jondubois
approved these changes
Feb 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing integration tests on lisk-p2p. Cover different scenarios like, for example, when a couple of nodes become unresponsive due to some reason, other nodes connected should be able to detect and update their network status gracefully.
Review checklist