Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Update test to check reject amount zero for transfer transaction #837

Closed
shuse2 opened this issue Nov 5, 2018 · 0 comments
Closed

Update test to check reject amount zero for transfer transaction #837

shuse2 opened this issue Nov 5, 2018 · 0 comments
Labels
🐛bug *easy lisk-transactions

Comments

@shuse2
Copy link
Contributor

shuse2 commented Nov 5, 2018 •
edited
Loading

Expected behavior

Type 0 transactinos with amount 0 should be rejected to sign, and the test also should be updated

https://github.com/LiskHQ/lisk-elements/blob/development/packages/lisk-transactions/test/utils/get_transaction_bytes.js#L110

Actual behavior

Amount zero is accepted

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

1.0-
@shuse2 shuse2 mentioned this issue Nov 5, 2018
Merged
@shuse2 shuse2 closed this as completed Nov 6, 2018
@shuse2 shuse2 reopened this Nov 6, 2018
@shuse2 shuse2 changed the title Reject amount zero for transfer transaction Update test to check reject amount zero for transfer transaction Nov 6, 2018
@shuse2 shuse2 removed the patch label Nov 6, 2018
@mitsuaki-u mitsuaki-u self-assigned this Nov 9, 2018
@mitsuaki-u mitsuaki-u mentioned this issue Nov 12, 2018
Merged
shuse2 added a commit that referenced this issue Nov 13, 2018
@shuse2
Merge pull request #840 from LiskHQ/837-Update_zero_amount_test
678c916 
Remove outdated zero transfer amount test - Closes #837
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐛bug *easy lisk-transactions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shuse2 @mitsuaki-u