This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 64
parseEncryptedPassphrase and decryptPassphraseWithPassword combination should return proper error #688
Labels
Comments
nazarhussain
changed the title
parseEncryptedPassphrase should return proper error
parseEncryptedPassphrase and decryptPassphraseWithPassword combination should return proper error
Jun 11, 2018
@nazarhussain How did you generate this string? |
From some tests in the core. 😄 |
willclarktech
added a commit
that referenced
this issue
Jul 10, 2018
willclarktech
added a commit
that referenced
this issue
Jul 13, 2018
willclarktech
added a commit
that referenced
this issue
Jul 13, 2018
willclarktech
added a commit
that referenced
this issue
Jul 16, 2018
willclarktech
added a commit
that referenced
this issue
Jul 16, 2018
Add validation to decrypt passphrase - Closes #688
Closed by #709 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
lisk.default.cryptography.parseEncryptedPassphrase
when used in combination oflisk.default.cryptography.decryptPassphraseWithPassword
is not returning valid error in case of no salt providedSteps to Reproduce
Expected behavior:
I expect error
No salt provided
Actual behavior:
I expect error
Argument must be a string
. This makes it confusing for user to understand the error, which element is missing or not provided in encrypted passphrase.Reproduces how often:
Always
Versions
1.0.0-beta.4
The text was updated successfully, but these errors were encountered: