Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users unable to vote more than 2 delegates at same time #3940

Closed
Tracked by #3963
ManuGowda opened this issue Nov 19, 2021 · 1 comment · Fixed by #3999
Closed
Tracked by #3963

Users unable to vote more than 2 delegates at same time #3940

ManuGowda opened this issue Nov 19, 2021 · 1 comment · Fixed by #3999
Assignees
Milestone

Comments

@ManuGowda
Copy link
Contributor

ManuGowda commented Nov 19, 2021

Expected behavior

At any given point in time users can vote 10 unique address/account.

For a given vote transaction users should be able to:

  • Upvote upto 10
  • Downvote upto 10

Info: https://github.com/LiskHQ/lisk-sdk/blob/2593d1fe70154a9209b713994a252c494cad7123/framework/src/modules/dpos/transaction_assets/vote_transaction_asset.ts#L81

Note: Delegate address must be unique among Upvote and Downvote

Actual behavior

Unable to vote more than 2 delegates in one transaction. Error You can't vote for more than 10 delegates.

Screenshot 2021-11-19 at 23 09 48

Steps to reproduce

  • Add votes to more than 2 delegates
  • Open Voting queue modal
  • Observe the error You can't vote for more than 10 delegates.

Which version(s) does this affect? (Environment, OS, etc...)

2.1.0

@reyraa
Copy link
Contributor

reyraa commented Nov 22, 2021

I suspect you have already voted 8 or 9 delegates. Therefore you see this error. Although I must agree there's a UX issue with the current error handling which we must resolve.

@ann-vashchenko many of our users seem to make this mistake. They think they should be able to vote for up to 10 delegates here, while they can't. Cause they've already voted for some other delegates.
I think we should display the current/used number of votes, and the make the remaining votes clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants