This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Update account command to typescript - Closes #654 #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
changed the base branch from
653-update_utils_to_typescript
to
649-convert_to_typescript
shuse2
force-pushed
the
654-update_account_cmd_ts
branch
from
5470e11 to
6c15627
Compare
shuse2
force-pushed
the
654-update_account_cmd_ts
branch
from
cf52e54 to
57079b8
Compare
shuse2
changed the base branch from
649-convert_to_typescript
to
676-update_lisk_elements
shuse2
changed the base branch from
676-update_lisk_elements
to
649-convert_to_typescript
mitsuaki-u
approved these changes
Dec 11, 2018
package.json
Outdated
| "chai": "4.1.2", | ||
| "chai-as-promised": "7.1.1", | ||
| "coveralls": "3.0.0", | ||
| "globby": "8.0.1", |
There was a problem hiding this comment.
It was complaining from the oclif, but it seems like not related.
I will remove this
src/commands/account/create.ts
Outdated
| const { flags: { number: numberStr } } = this.parse(CreateCommand); | ||
| const number = parseInt(numberStr, 10); | ||
| const numberOfAccount = parseInt(numberStr as string, 10); |
There was a problem hiding this comment.
prefer numberOfAccounts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update base class and account commands to use typescript
Review checklist