Update utils to typescript - Closes #653 #664
Conversation
src/utils/api.ts
Outdated
|
|
||
| export default getAPIClient; | ||
| return new APIClient(clientNodes, { nethash }); | ||
| }; |
| "@types/sinon": "5.0.5", | ||
| "@types/sinon-chai": "3.2.0", | ||
| "@types/strip-ansi": "3.0.0", | ||
| "@oclif/dev-cli": "1.18.0", |
There was a problem hiding this comment.
shouldn't @oclif dependencies come before @types?
src/utils/input/utils.ts
Outdated
| const ERROR_DATA_MISSING = 'No data was provided.'; | ||
| const ERROR_DATA_SOURCE = 'Unknown data source type.'; | ||
| const DEFAULT_TIMEOUT = 100; | ||
|
|
||
| export const splitSource = source => { | ||
| interface SplittedSource { |
src/utils/input/utils.ts
Outdated
| export const getPassphrase = async ( | ||
| passphraseSource: string, | ||
| options: object, | ||
| ): Promise<string | ReadonlyArray<string>> => { |
There was a problem hiding this comment.
do we need | ReadonlyArray<string>
| // Get endpoints with 2xx status code should always return with data key. | ||
| if (!res.data) { | ||
| throw new Error('No data was returned.'); | ||
| } | ||
| if (Array.isArray(res.data)) { | ||
| if (isArray(res.data)) { |
There was a problem hiding this comment.
why not regular Array.isArray?
There was a problem hiding this comment.
Type detection didn't work well here...
| @@ -13,8 +13,8 @@ | |||
| * Removal or modification of this copyright notice is prohibited. | |||
| * | |||
| */ | |||
| export const createFakeInterface = value => ({ | |||
| on: (type, callback) => { | |||
| export const createFakeInterface = (value: any) => ({ | |||
There was a problem hiding this comment.
do we need tslint disable no-any here?
There was a problem hiding this comment.
For test, it seems like any is working =0
| @@ -51,7 +64,11 @@ describe('query utils', () => { | |||
| get: sandbox.stub().resolves(response), | |||
| }, | |||
| }; | |||
| queryResult = query(apiClient, defaultEndpoint, defaultParameters); | |||
| queryResult = query( | |||
| (apiClient as unknown) as APIClient, | |||
There was a problem hiding this comment.
it needed to convert to unknown first otherwise it complains...
src/utils/query.ts
Outdated
| return res.data; | ||
| }; | ||
|
|
||
| export const query = async (client, endpoint, parameters) => | ||
| Array.isArray(parameters) | ||
| interface QueryParamter { |
There was a problem hiding this comment.
QueryParamter --> QueryParameter
shuse2
changed the base branch from
652-update_to_typescript_setting
to
649-convert_to_typescript
package.json
Outdated
| @@ -104,15 +104,15 @@ | |||
| "/default_config.json" | |||
| ], | |||
| "dependencies": { | |||
| "@oclif/command": "1.5.0", | |||
There was a problem hiding this comment.
why @oclif dependencies were moved up?
There was a problem hiding this comment.
probably npm? but fixed.
| @@ -13,7 +13,7 @@ | |||
| * Removal or modification of this copyright notice is prohibited. | |||
| * | |||
| */ | |||
| import stripANSI from 'strip-ansi'; | |||
| import strip_ansi from 'strip-ansi'; | |||
There was a problem hiding this comment.
why changed to snake_case?
There was a problem hiding this comment.
this was tslint rule, strip-ansi is exposing function, and it should be used as it's named.
| @@ -82,7 +82,9 @@ export const getStdIn = ({ | |||
| dataIsRequired | |||
| ) | |||
| ) { | |||
| return resolve({}); | |||
| resolve({}); | |||
There was a problem hiding this comment.
return resolve({}) was fine I guess or was there any reason?
There was a problem hiding this comment.
tslint rule, where if void is return type, we shouldn't return value, and explicitly do return in new line
Description
Updated utils folder into typescript.
This will fail until
lisk-elements 2.0is released.Review checklist