This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Add command to get unsigned and unprocessed transactions - Closes#600 #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
Nov 12, 2018
|
@shuse2 Addressed |
shuse2
previously approved these changes
Nov 13, 2018
mitsuaki-u
reviewed
Nov 14, 2018
There was a problem hiding this comment.
Should we also allow get unsigned tx by sender ID (as per issue #600 suggestion), or allow for getting unsigned / unprocessed tx from node without specific tx IDs?
src/commands/transaction/get.js
Outdated
| const client = getAPIClient(this.userConfig.api); | ||
|
|
||
| if (txnState && txnState === 'unsigned') { |
There was a problem hiding this comment.
just if (txnState === 'unsigned') ?
src/commands/transaction/get.js
Outdated
| const results = await queryNode(client.node, txnState, req); | ||
| return this.print(results); | ||
| } | ||
| if (txnState && txnState === 'unprocessed') { |
mitsuaki-u
approved these changes
Nov 14, 2018
shuse2
approved these changes
Nov 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to add a command to get transactions in
unsignedandunprocessedstate.Example,
lisk transaction:get 1260076503909567890 --state=unsignedReview checklist