Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Add delegate:votes and voters - Closes #168 #636

Merged
merged 6 commits into from
Nov 1, 2018

Conversation

mitsuaki-u
Copy link
Contributor

What was the problem?

No commands for get voters and votes for delegates.

How did I fix it?

Added commands and tests.

How to test it?

npm run test

Review checklist

@mitsuaki-u mitsuaki-u added this to the Version 2.1.0 milestone Oct 30, 2018
@mitsuaki-u mitsuaki-u self-assigned this Oct 30, 2018
@mitsuaki-u mitsuaki-u requested a review from shuse2 October 30, 2018 16:45
shuse2
shuse2 previously requested changes Oct 31, 2018
src/commands/delegate/voters.js Outdated Show resolved Hide resolved
src/commands/delegate/voters.js Show resolved Hide resolved
src/commands/delegate/votes.js Show resolved Hide resolved
test/commands/delegate/voters.test.js Outdated Show resolved Hide resolved
test/commands/delegate/voters.test.js Outdated Show resolved Hide resolved
@shuse2
Copy link
Contributor

shuse2 commented Nov 1, 2018

Also, please add the documentation =)

shuse2
shuse2 previously requested changes Nov 1, 2018
test/commands/delegate/voters.test.js Outdated Show resolved Hide resolved
test/commands/delegate/votes.test.js Outdated Show resolved Hide resolved
@shuse2 shuse2 merged commit 768ac80 into release/2.0.0 Nov 1, 2018
@shuse2 shuse2 deleted the 168-delegate_votes_voters branch November 1, 2018 15:42
@mitsuaki-u mitsuaki-u restored the 168-delegate_votes_voters branch November 1, 2018 15:47
shuse2 added a commit that referenced this pull request Nov 1, 2018
@shuse2 shuse2 removed this from the Version 2.1.0 milestone Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants