This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
619-Migrate signature:create command #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuaki-u
changed the title
mitsuaki-u
changed the title
shuse2
previously requested changes
Oct 2, 2018
src/commands/signature/create.js
Outdated
| `; | ||
|
|
||
| CreateCommand.examples = [ | ||
| 'signature:create \'{"type":0,"amount":"10","recipientId":"100L","senderPublicKey":"abcd1234","timestamp":59353522,"asset":{},"id":"abcd1234","signature":"abcd1234"}\'', |
| .stub( | ||
| elements.default.transaction, | ||
| 'createSignatureObject', | ||
| transactionStub, |
There was a problem hiding this comment.
why not put the sandbox.stub().returns(defaultSignatureObject) as return value here?
|
One thing I forgot to mention, we we add a new feature, let's update the README at the same time.
|
shuse2
approved these changes
Oct 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Commander 2.0 doesn't have a way to signature for multi-signature transaction.
How did I fix it?
Create
signature:createcommandHow to test it?
Build, lint, test.
Review checklist