620 - Update util std functions

[mitsuaki-u]

What was the problem?

Related to PR: #622
Race condition in getRawStdin causing inconsistent results when piping.

How did I fix it?

Update getStdin func, remove getRawStdin and promise.race.

How to test it?

./bin/run transaction:create -t=0 100 100L --passphrase="pass:123" | ./bin/run transaction:sign --passphrase="pass:123"

Review checklist

• The PR resolves Command throws an error when connecting with pipe #620
• All new code is covered with unit tests
• All new code was formatted with Prettier
• Linting passes
• Tests pass
• Commit messages follow the commit guidelines
• Documentation has been added/updated

[shuse2]

I think it's strange to resolve a Promise here.

[shuse2]

if we wrap the promise, I think we can remove Promise.race

[shuse2]

Shouldn't we clearTimeout in normal scenario?
Also, this doesn't throw error, so what are we doing for try-catch...? do we need Promise here?

[shuse2]

I haven't thought about how to clean it up, but intended functionality is something like this?
Maybe we can chain this function to handleClose part so it uses getRawStdIn in getStdIn and it just handles the output nicely?

const readFromStd = new Promise((resolve, reject) => {
	const rl = readline.createInterface({ input: process.stdin });
	const lines = [];
	rl
		.on('line', line => lines.push(line))
		.on('close', () => resolve(lines));

	const id = setTimeout(() => {
		clearTimeout(id);
		if (stdinIsTTY()) {
			reject(new Error(`Timed out after ${DEFAULT_TIMEOUT} ms`));
		} else {
			resolve(lines);
		}
	}, DEFAULT_TIMEOUT);
});
return readFromStd;

Addressed.

[shuse2]

I think you should just return readFromStd here

[shuse2]

this content of resolve should be consistent with the other resolve

[shuse2]

I think it's probably easier to change handleClose to function (line: string[]) => { passphrase, second... }, then call from close event and timeout event

Addressed.

[shuse2]

LGTM GJ