This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Add filter of args in account:get command #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willclarktech
previously requested changes
Aug 3, 2018
test/commands/account/get.test.js
Outdated
| { | ||
| query: { | ||
| limit: 1, | ||
| address: addresses[0], |
There was a problem hiding this comment.
It's the same thing, but would make more sense if these were both addressesWithEmpty[0]. Probably also applies to the blocks test.
willclarktech
approved these changes
Aug 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
When the command had trailing comma, it was causing error from the API
How did I fix it?
Add filter after splitting the args
How to test it?
Review checklist