This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Remove process exit from config commands - closes #580 #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
Jul 30, 2018
| @@ -20,20 +20,18 @@ import defaultConfig from '../../default_config.json'; | |||
| import { CONFIG_VARIABLES } from './constants'; | |||
| import { ValidationError } from './error'; | |||
| import { readJSONSync, writeJSONSync } from './fs'; | |||
| import logger from './logger'; | |||
There was a problem hiding this comment.
I think this was actually the only place the logger was used.
Since we use the logger from the oclif now, i think we are good to delete this function
test/utils/config.js
Outdated
| expect(process.exit).to.be.calledWithExactly(1); | ||
| return expect(logger.error).to.be.calledWithExactly( | ||
| `ERROR: Could not write to \`${defaultPath}\`. Your configuration will not be persisted.`, | ||
| return expect(() => getConfig(defaultPath)).to.throw( |
There was a problem hiding this comment.
In other test suite, we do something like getConfig.bind(null, defaultPath)
so as other places below.
shuse2
approved these changes
Jul 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review checklist