Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Fix UnhandledPromiseRejectionWarning - closes #582 #585

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

yatki
Copy link
Contributor

@yatki yatki commented Jul 30, 2018

What was the problem?

2 tests were throwing UnhandledPromiseRejectionWarning

How did I fix it?

We decided to combine two tests into one, since one of them was returning PromiseRejection anyway.

Review checklist

@yatki yatki self-assigned this Jul 30, 2018
@yatki yatki requested review from shuse2 and willclarktech July 30, 2018 12:09
Copy link
Contributor

@willclarktech willclarktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more direct solution would return queryResult.catch(() => {}) from the beforeEach hook. That way we wouldn't have to change our test code.

@shuse2
Copy link
Contributor

shuse2 commented Jul 30, 2018

yea, that might have been easier, but we thought those two separate tests were more like the same case running twice

@willclarktech
Copy link
Contributor

@shuse2 I'm ok with it

@shuse2 shuse2 merged commit 21d3f83 into 2.0.0 Jul 30, 2018
@shuse2 shuse2 deleted the 582-promise-rejection-warnings branch July 30, 2018 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants