Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add check on total weight and certificate threshold in verifyValidatorsUpdate #9039

Closed
shuse2 opened this issue Sep 25, 2023 · 0 comments
Closed
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Sep 25, 2023

Expected behavior

Add additional verification logic as defined in the PR

Actual behavior

In LIP0053, in the context of posting a certificate within a CCU, we allow the new certificate threshold to be set to any value. In particular, it can be set to a value less than 1/3 of the total BFT weight or even to 0, thus allowing a following certificate to be signed by a minority of validators not satisfying the BFT requirements.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-rc-2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants