Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update message recovery command verification #8721

Closed
Tracked by #7226
ishantiw opened this issue Jul 11, 2023 · 2 comments
Closed
Tracked by #7226

Update message recovery command verification #8721

ishantiw opened this issue Jul 11, 2023 · 2 comments
Assignees
@Phanco
Labels
framework/module/interoperability Interoperability module
Milestone
Sprint 102

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Jul 11, 2023 •
edited
Loading

Description

Update message recovery init command verification and execution based on LIP PR LiskArchive/lips#399

Verification: Add additional cheap check in verification of message recovery command to ensure that the indices of all provides messages are in the range [0, ..., outboxSize -1]
Execution: Emit EVENT_NAME_INVALID_SMT_VERIFICATION

Acceptance Criteria

  • Should have all the unit tests

Additional Information
@ishantiw ishantiw added the framework/module/interoperability Interoperability module label Jul 11, 2023
@ishantiw ishantiw changed the title Update message recovery command verification Update message recovery init command verification Jul 11, 2023
@ishantiw ishantiw mentioned this issue Jul 11, 2023
Merged
@AndreasKendziorra
Copy link
Contributor

Execution: Emit EVENT_NAME_INVALID_SMT_VERIFICATION

Maybe it's clear from the first sentence, but also SMTVerify must be moved from verification to execution.

@ishantiw ishantiw mentioned this issue Jul 19, 2023
Closed
@Madhulearn Madhulearn added this to the Sprint 101 milestone Aug 1, 2023
@Phanco Phanco self-assigned this Aug 8, 2023
@Phanco Phanco mentioned this issue Aug 10, 2023
Merged
@Phanco
Copy link
Contributor

Phanco commented Aug 10, 2023

For the Execution part, it has been well implemented by @mitsuaki-u 's PR
#8816

@ishantiw ishantiw changed the title Update message recovery init command verification Update message recovery command verification Aug 10, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 101, Sprint 102 Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Phanco Phanco

Labels
framework/module/interoperability Interoperability module
Projects
None yet
Milestone
Sprint 102
Development

No branches or pull requests
4 participants
@ishantiw @Phanco @AndreasKendziorra @Madhulearn