Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Send method may lead to crash when missing the timestamp parameter #8607

Closed
Tracked by #7226
ishantiw opened this issue Jun 16, 2023 · 0 comments
Closed
Tracked by #7226

Send method may lead to crash when missing the timestamp parameter #8607

ishantiw opened this issue Jun 16, 2023 · 0 comments
Assignees
Milestone

Comments

@ishantiw
Copy link
Contributor

Description

The send method of the interoperability module receives an optional timestamp parameter, which is not specified in the LIP and may lead to crashes when not set.

https://github.com/LiskHQ/lisk-sdk/blob/89e7504ef5eb6183aefe576a93be3d6052e56038/framework/src/modules/interoperability/base_interoperability_method.ts#L125-L147

On sends originating from the mainchain, the timestamp parameter is used to check the liveness of a chain with the isLive) function (sidechains do not check the liveliness of other chains). So, if this optional parameter is not set when calling send on the mainchain, the code will throw an exception. This is what happens with the transferCrossChain method of the token module which does not pass a timestamp to the send function. If the mainchain uses the transferCrossChain method, the send will unconditionally fail because the isLive function throws an exception when trying to use the undefined timestamp.

Affected Version

v6.0.0-beta.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants