You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
The folders containing generated protocol fixtures were not updated from dpos to pos. Also the symlinks in framework/test/fixtures/ which point to those fixture folders were also not updated:
This is currently not an issue, because both fixtures and symlinks use the old names.
However, when there is a change in protocol and it is needed to re-generate protocol fixtures, running the fixture generator such as protocol-specs/generators/pos_random_seed_generation/index.js will not overwrite the existing fixtures. Instead, it will store the newly generated fixtures in protocol-specs/generator_outputs/pos_random_seed_generation and the symlinks will still point to the old fixtures in dpos folder.
Expected behavior
After generating new protocol fixtures, the tests which use them should use the newly generated version, instead of the old version from dpos folder.
Steps to reproduce
Run protocol-specs/generators/pos_random_seed_generation/index.js
The new fixtures will be created in protocol-specs/generator_outputs/pos_random_seed_generation/
The tests which import fixtures from framework/test/fixtures/ folder will still use old fixtures from dpos_random_seed_generation
The text was updated successfully, but these errors were encountered:
Actual behavior
The folders containing generated protocol fixtures were not updated from
dpos
topos
. Also the symlinks inframework/test/fixtures/
which point to those fixture folders were also not updated:This is currently not an issue, because both fixtures and symlinks use the old names.
However, when there is a change in protocol and it is needed to re-generate protocol fixtures, running the fixture generator such as
protocol-specs/generators/pos_random_seed_generation/index.js
will not overwrite the existing fixtures. Instead, it will store the newly generated fixtures inprotocol-specs/generator_outputs/pos_random_seed_generation
and the symlinks will still point to the old fixtures indpos
folder.Expected behavior
After generating new protocol fixtures, the tests which use them should use the newly generated version, instead of the old version from
dpos
folder.Steps to reproduce
protocol-specs/generators/pos_random_seed_generation/index.js
protocol-specs/generator_outputs/pos_random_seed_generation/
framework/test/fixtures/
folder will still use old fixtures fromdpos_random_seed_generation
The text was updated successfully, but these errors were encountered: