-
Notifications
You must be signed in to change notification settings - Fork 454
Wrong block reward calculation #8502
Comments
at the time of writing the comment, the behavior changed, every validator gets the same amount of LSK no matter the vote weight (which is also incorrect) |
Getting 500 LSK per round is correct
if there is less than 103 validators in betanet, for example, only 2 validators. The length of the round will become |
@shuse2 So, you're saying that the inflation rate on a chain is not constant and is higher when the number of active validators is lower? |
if there is lower than 103 in the lisk mainchain case, the inflation rate will be higher corresponding to the real time. |
Looking at the current situation,
|
Checking capping, it looks like capping is working as expected (the weight is capped with some configuration: currently 5%) so that the difference wont be too big within the active validators |
@shuse2 check this out especially at the also are you sure the rounds get shorter? currently there are 22 validators, and the round is definitely 103 blocks long, delegates get reshuffled every 103 blocks |
Round length is suppose to be shorter but we have this issue #8562. For the shift between "height":129073" - "height":129045", im guessing there was less than or equal to 20 validators. with 5% BFT cap, until 20 validators, there is no capping, so there could be big differences in the reward between validators. at the height
|
Thank you @shuse2 everything is more clear now, the round length, the cap switch at 20 validatora, got me all confused 👍 |
I'll close the issue as resolved 👍 |
Expected behavior
The block rewards should be calculated correctly for every validator
Actual behavior
Currently on betanet the amount of validators is below 103, I believe because of that reason, the dynamic reward module is miscalculating the block rewards for every delegate, it assigns the expected ~500 LSK per round proportionally to the validators, but since there is less than 103 validator, they mint the blocks multiple times in a round, making the inflation higher than expected
Steps to reproduce
Check the current block rewards on the betanet and the inflation.
Which version(s) does this affect? (Environment, OS, etc...)
SDK 6.0-beta
The text was updated successfully, but these errors were encountered: