You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
All the params must be validated against the schema at some point.
Consider moving the schema validation into state machine where the params is decoded
the reason why the property validation was done on each module was to ensure each module is responsible for writing the test for this.
If we move the validation to the state machine, the validation becomes responsibility of state machine and on the unit test, the param validation will not be tested on each module.
In the past, there was a bug introduced the bug because of this.
Additionally, for cross-chain command, currently the params is not decoded on submitCrossChainUpdate command. Therefore, if we introduce the validation, it will be required to decode twice unless we change the context
Expected behavior
All the params must be validated against the schema at some point.
Consider moving the schema validation into state machine where the params is decoded
Actual behavior
Steps to reproduce
N/A
Which version(s) does this affect? (Environment, OS, etc...)
6.0.0-alpha.2
The text was updated successfully, but these errors were encountered: