Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Missing test cases for CommitPool.verifyAggregateCommit() #8376

Closed
Tracked by #7210
bobanm opened this issue Apr 20, 2023 · 0 comments · Fixed by #8377
Closed
Tracked by #7210

Missing test cases for CommitPool.verifyAggregateCommit() #8376

bobanm opened this issue Apr 20, 2023 · 0 comments · Fixed by #8377
Assignees
@bobanm
Labels
framework
Milestone
Sprint 93

Comments

@bobanm
Copy link
Contributor

bobanm commented Apr 20, 2023

Compared to the functionality defined in LIP-0061, the unit test suite is missing 2 test cases for CommitPool.verifyAggregateCommit():

  1. Return false when provided aggregate commit is invalid
  2. Return true when when aggregate commit is empty, and height is equal to maxHeightCertified
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobanm bobanm

Labels
framework
Projects
None yet
Milestone
Sprint 93
Development

Successfully merging a pull request may close this issue.

Add 2 missing test cases for CommitPool.verifyAggregateCommit() LiskArchive/lisk-sdk
2 participants
@shuse2 @bobanm