Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Allow same commission in the change commission #8224

Closed
Tracked by #7210
shuse2 opened this issue Mar 3, 2023 · 0 comments · Fixed by #8248
Closed
Tracked by #7210

Allow same commission in the change commission #8224

shuse2 opened this issue Mar 3, 2023 · 0 comments · Fixed by #8248
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Mar 3, 2023

Description

In the changeCommission command execution, lastCommission increased height should be increased when value are the same as in below

if trsParams.newCommission >= oldCommission:
        b = block including trs
        validatorStore(senderAddress).lastCommissionIncreaseHeight = b.header.height

Acceptance Criteria

  • It should test the case where trsParams.newCommission == oldCommission:

Additional Information

Related LIP

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants