Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Module name mis-alignment in with LIP-45 #8177

Closed
Tracked by #7210
Phanco opened this issue Feb 23, 2023 · 0 comments · Fixed by #8209
Closed
Tracked by #7210

Module name mis-alignment in with LIP-45 #8177

Phanco opened this issue Feb 23, 2023 · 0 comments · Fixed by #8209
Assignees
@Phanco
Labels
framework/module/interoperability Interoperability module type: bug
Milestone
Sprint 90

Comments

@Phanco
Copy link
Contributor

Phanco commented Feb 23, 2023 •
edited
Loading

Expected behavior

  • RegisterSidechainCommand should call ccm with module name that would be picked up by BaseCCRegistrationCommand
  • command names should match with LIP

Actual behavior

  • BaseCCRegistrationCommand is using CROSS_CHAIN_COMMAND_NAME_REGISTRATION which equals to registration
  • RegisterSidechainCommand is using CROSS_CHAIN_COMMAND_REGISTRATION that equals to crossChainCommandRegistration
  • command name not math, _NAME is unexpected here

Steps to reproduce

N/A

Which version(s) does this affect? (Environment, OS, etc...)

v6.0.0-alpha.14
@Phanco Phanco self-assigned this Feb 28, 2023
@Madhulearn Madhulearn added this to the Sprint 90 milestone Feb 28, 2023
@Phanco Phanco mentioned this issue Mar 2, 2023
Merged
@Phanco Phanco changed the title Module name mis-alignment in BaseCCRegistrationCommand Module name mis-alignment in with LIP-45 Mar 6, 2023
@Madhulearn Madhulearn mentioned this issue Mar 30, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Phanco Phanco

Labels
framework/module/interoperability Interoperability module type: bug
Projects
None yet
Milestone
Sprint 90
Development

Successfully merging a pull request may close this issue.

Align module names with LIP-45 LiskArchive/lisk-sdk
2 participants
@Phanco @Madhulearn