Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Unit test review - Reward module #8087

Closed
Tracked by #7245
vjaiman opened this issue Jan 26, 2023 · 0 comments
Closed
Tracked by #7245

Unit test review - Reward module #8087

vjaiman opened this issue Jan 26, 2023 · 0 comments
Assignees
@mosmartin
Labels
type: bug type: test
Milestone
Sprint 107

Comments

@vjaiman
Copy link

vjaiman commented Jan 26, 2023

endpoint.spec.ts:

  • I am not sure if the formula to calculate getAnnualInflation() is correct. It is an upper bound value of rewards minted per year but not an inflation rate. In my understanding, inflation rate should be w.r.t total supply. For example,

InflationRate = (blocksPerYear * rewardAtHeight)/totalSupplyLSK
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mosmartin mosmartin

Labels
type: bug type: test
Projects
None yet
Milestone
Sprint 107
Development

No branches or pull requests
3 participants
@mosmartin @vjaiman @Madhulearn